Page MenuHomePhabricator
Create Task
Maniphest T395214

Multiple test failures for MediaWiki\Minerva\SkinMinervaTest::testHasPageTabs
Closed, ResolvedPublic
Actions

Description

22:00:32 There were 4 failures:
22:00:32 
22:00:32 1) MediaWiki\Minerva\SkinMinervaTest::testHasPageTabs with data set #1 (array(false), 0, 'Main Page', 'view', false)
22:00:32 Failed asserting that true matches expected false.
22:00:32 
22:00:32 /workspace/src/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php:207
22:00:32 
22:00:32 2) MediaWiki\Minerva\SkinMinervaTest::testHasPageTabs with data set #2 (array(false), 1, 'Main Page', 'view', false)
22:00:32 Failed asserting that true matches expected false.
22:00:32 
22:00:32 /workspace/src/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php:207
22:00:32 
22:00:32 3) MediaWiki\Minerva\SkinMinervaTest::testGetTabsDataNoPageTabs
22:00:32 Failed asserting that two arrays are equal.
22:00:32 --- Expected
22:00:32 +++ Actual
22:00:32 @@ @@
22:00:32  Array (
22:00:32 +    'items' => Array (...)
22:00:32 +    'id' => Array (...)
22:00:32  )
22:00:32 
22:00:32 /workspace/src/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php:263
22:00:32 
22:00:32 4) MediaWiki\Minerva\SkinMinervaTest::testMainPageTalkButton
22:00:32 Failed asserting that an array has the key 'talk'.
22:00:32 
22:00:32 /workspace/src/skins/MinervaNeue/tests/phpunit/skins/SkinMinervaTest.php:781

These are breaking CI on multiple repos:

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.May 25 2025, 8:20 PM
kostajh triaged this task as Unbreak Now! priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2025, 8:20 PM
kostajh updated the task description. (Show Details)May 25 2025, 8:21 PM
Reedy added a project: PHP 8.1 support.May 25 2025, 9:12 PM
Reedy subscribed.

Some cross reference to T328921: Drop PHP 7.4 and PHP 8.0 support from MediaWiki no doubt...

matmarex subscribed.May 26 2025, 7:22 AM
matmarex added a comment.May 26 2025, 7:40 AM

Minerva has some special cases for viewing the main page, and it seems those cases no longer trigger in tests – Title::isMainPage() returns false when it should return true.

That method has an internal cache, maybe the wrong value is being cached in some other test?

I can't reproduce the failure locally.

kostajh added a project: Web-Team.May 26 2025, 8:39 AM
kostajh added a subscriber: SToyofuku-WMF.May 26 2025, 8:41 AM
dcausse subscribed.May 26 2025, 9:50 AM
gmodena subscribed.May 26 2025, 10:03 AM
jnuche added a parent task: T392173: 1.45.0-wmf.3 deployment blockers.May 26 2025, 11:09 AM
Ladsgroup subscribed.May 26 2025, 12:15 PM
Daimona subscribed.May 26 2025, 12:28 PM
gerritbot added a comment.May 26 2025, 2:23 PM

Change #1150702 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/MinervaNeue@master] Temporarily skip failing unit tests

https://gerrit.wikimedia.org/r/1150702

gerritbot added a project: Patch-For-Review.May 26 2025, 2:23 PM
• mszabo subscribed.May 26 2025, 2:48 PM
In T395214#10855722, @matmarex wrote:

Minerva has some special cases for viewing the main page, and it seems those cases no longer trigger in tests – Title::isMainPage() returns false when it should return true.

That method has an internal cache, maybe the wrong value is being cached in some other test?

I can't reproduce the failure locally.

That seems correct. I pasted the failing split group config into my local PHPUnit setup and ran it, which reproduced the issue. I confirmed that $cachedMainPage was holding an unexpected value, with (mainpage) as the DB key. That gets there from \Wikibase\Repo\Tests\Specials\SpecialItemsWithoutSitelinksTest::testExecute -> OutputPageParserOutput -> MobileFrontend.

I'll make a patch to clear it.

gerritbot added a comment.May 26 2025, 3:06 PM

Change #1150710 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] title: Reset cached Title objects between tests

https://gerrit.wikimedia.org/r/1150710

gerritbot added a comment.May 26 2025, 3:16 PM

Change #1150702 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Temporarily skip failing unit tests

https://gerrit.wikimedia.org/r/1150702

Winston_Sung subscribed.May 26 2025, 3:16 PM
gerritbot added a comment.May 26 2025, 3:26 PM

Change #1150713 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/Echo@master] DiscussionParserTest: Fix false negative due to reused Title instance

https://gerrit.wikimedia.org/r/1150713

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).May 26 2025, 4:00 PM
ovasileva subscribed.May 26 2025, 4:01 PM
gerritbot added a comment.May 26 2025, 5:31 PM

Change #1150713 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] DiscussionParserTest: Fix false negative due to reused Title instance

https://gerrit.wikimedia.org/r/1150713

matmarex closed this task as Resolved.May 26 2025, 7:23 PM
matmarex claimed this task.

The deployment is unblocked. I'll merge @mszabo's patch and unskip the tests after the branch cut.

gerritbot added a comment.May 26 2025, 10:04 PM

Change #1150780 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] phpunit: Remove superfluous Title::clearCaches() calls

https://gerrit.wikimedia.org/r/1150780

gerritbot added a comment.May 27 2025, 10:02 AM

Change #1150710 merged by jenkins-bot:

[mediawiki/core@master] title: Reset cached Title objects between tests

https://gerrit.wikimedia.org/r/1150710

gerritbot added a comment.May 27 2025, 10:03 AM

Change #1150780 merged by jenkins-bot:

[mediawiki/core@master] phpunit: Remove superfluous Title::clearCaches() calls

https://gerrit.wikimedia.org/r/1150780

Maintenance_bot removed a project: Patch-For-Review.May 27 2025, 10:30 AM
gerritbot added a comment.May 27 2025, 10:42 AM

Change #1151162 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/Wikibase@master] phpunit: Remove superfluous Title::clearCaches() calls

https://gerrit.wikimedia.org/r/1151162

gerritbot added a project: Patch-For-Review.May 27 2025, 10:42 AM
gerritbot added a comment.May 27 2025, 10:50 AM

Change #1151163 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] Revert "Temporarily skip failing unit tests"

https://gerrit.wikimedia.org/r/1151163

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.4; 2025-06-03); removed MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).May 27 2025, 11:00 AM
gerritbot added a comment.May 27 2025, 11:03 AM

Change #1151168 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/core@REL1_44] title: Reset cached Title objects between tests

https://gerrit.wikimedia.org/r/1151168

gerritbot added a comment.May 27 2025, 11:03 AM

Change #1151169 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/extensions/Echo@REL1_44] DiscussionParserTest: Fix false negative due to reused Title instance

https://gerrit.wikimedia.org/r/1151169

gerritbot added a comment.May 27 2025, 11:17 AM

Change #1151162 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] phpunit: Remove superfluous Title::clearCaches() calls

https://gerrit.wikimedia.org/r/1151162

gerritbot added a comment.May 27 2025, 11:23 AM

Change #1151172 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/extensions/Echo@REL1_43] DiscussionParserTest: Fix false negative due to reused Title instance

https://gerrit.wikimedia.org/r/1151172

gerritbot added a comment.May 27 2025, 11:31 AM

Change #1151169 merged by jenkins-bot:

[mediawiki/extensions/Echo@REL1_44] DiscussionParserTest: Fix false negative due to reused Title instance

https://gerrit.wikimedia.org/r/1151169

gerritbot added a comment.May 27 2025, 11:44 AM

Change #1151172 merged by jenkins-bot:

[mediawiki/extensions/Echo@REL1_43] DiscussionParserTest: Fix false negative due to reused Title instance

https://gerrit.wikimedia.org/r/1151172

gerritbot added a comment.May 27 2025, 12:34 PM

Change #1151191 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/core@REL1_43] title: Reset cached Title objects between tests

https://gerrit.wikimedia.org/r/1151191

gerritbot added a comment.May 27 2025, 12:34 PM

Change #1151192 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/core@REL1_44] phpunit: Remove superfluous Title::clearCaches() calls

https://gerrit.wikimedia.org/r/1151192

gerritbot added a comment.May 27 2025, 12:35 PM

Change #1151193 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/core@REL1_43] phpunit: Remove superfluous Title::clearCaches() calls

https://gerrit.wikimedia.org/r/1151193

gerritbot added a comment.May 27 2025, 12:38 PM

Change #1151194 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/extensions/Wikibase@REL1_44] phpunit: Remove superfluous Title::clearCaches() calls

https://gerrit.wikimedia.org/r/1151194

gerritbot added a comment.May 27 2025, 12:38 PM

Change #1151195 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/extensions/Wikibase@REL1_43] phpunit: Remove superfluous Title::clearCaches() calls

https://gerrit.wikimedia.org/r/1151195

gerritbot added a comment.May 27 2025, 12:42 PM

Change #1151168 merged by jenkins-bot:

[mediawiki/core@REL1_44] title: Reset cached Title objects between tests

https://gerrit.wikimedia.org/r/1151168

gerritbot added a comment.May 27 2025, 12:51 PM

Change #1151192 merged by jenkins-bot:

[mediawiki/core@REL1_44] phpunit: Remove superfluous Title::clearCaches() calls

https://gerrit.wikimedia.org/r/1151192

ReleaseTaggerBot added a project: MW-1.44-notes.May 27 2025, 1:00 PM
gerritbot added a comment.May 27 2025, 1:20 PM

Change #1151191 merged by jenkins-bot:

[mediawiki/core@REL1_43] title: Reset cached Title objects between tests

https://gerrit.wikimedia.org/r/1151191

gerritbot added a comment.May 27 2025, 1:23 PM

Change #1151193 merged by jenkins-bot:

[mediawiki/core@REL1_43] phpunit: Remove superfluous Title::clearCaches() calls

https://gerrit.wikimedia.org/r/1151193

ReleaseTaggerBot added a project: MW-1.43-notes.May 27 2025, 2:00 PM
gerritbot added a comment.May 27 2025, 2:30 PM

Change #1151163 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Revert "Temporarily skip failing unit tests"

https://gerrit.wikimedia.org/r/1151163

Krinkle awarded a token.May 28 2025, 1:38 PM
Bawolff subscribed.May 28 2025, 7:30 PM

It seems like the reset title cache patch may have broken scribunto tests, at least on the REL1_43 branch.

gerritbot added a comment.May 28 2025, 10:50 PM

Change #1151810 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/Scribunto@master] Add UriLibraryTest to the Database group

https://gerrit.wikimedia.org/r/1151810

gerritbot added a comment.May 28 2025, 11:23 PM

Change #1151810 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Add UriLibraryTest to the Database group

https://gerrit.wikimedia.org/r/1151810

gerritbot added a comment.May 28 2025, 11:48 PM

Change #1151815 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/extensions/Scribunto@REL1_43] Add UriLibraryTest to the Database group

https://gerrit.wikimedia.org/r/1151815

gerritbot added a comment.May 28 2025, 11:48 PM

Change #1151816 had a related patch set uploaded (by Reedy; author: Máté Szabó):

[mediawiki/extensions/Scribunto@REL1_44] Add UriLibraryTest to the Database group

https://gerrit.wikimedia.org/r/1151816

gerritbot added a comment.May 29 2025, 12:02 AM

Change #1151816 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@REL1_44] Add UriLibraryTest to the Database group

https://gerrit.wikimedia.org/r/1151816

gerritbot added a comment.May 29 2025, 12:05 AM

Change #1151815 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@REL1_43] Add UriLibraryTest to the Database group

https://gerrit.wikimedia.org/r/1151815

SToyofuku-WMF mentioned this in T395970: Verify 1.45.0-wmf.4 deployment.Jun 3 2025, 9:37 PM
gerritbot added a comment.Jun 10 2025, 8:01 PM

Change #1151194 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_44] phpunit: Remove superfluous Title::clearCaches() calls

https://gerrit.wikimedia.org/r/1151194

gerritbot added a comment.Jun 18 2025, 10:35 AM

Change #1151195 abandoned by Reedy:

[mediawiki/extensions/Wikibase@REL1_43] phpunit: Remove superfluous Title::clearCaches() calls

https://gerrit.wikimedia.org/r/1151195

Maintenance_bot removed a project: Patch-For-Review.Jun 18 2025, 11:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits