Page MenuHomePhabricator

[Analytics] [Refactor] Query subset conditionals can be simplified
Open, Needs TriagePublic

Description

Wikidata Analytics Bug Report

This task was generated using the Wikidata Analytics bug report form. Please use the task template linked on our project page to report bugs to the team. Thank you!

Behavior

Please provide a concise description of what you’re experiencing and what you’d expect to happen.

The queries for the query segmentation DAG are at times using conditionals that are logically impossible. This is because on writing sometimes the full conditional for one segment was dropped in as a negation within another, but then parts of the negated conditional can't occur given the WHERE clause conditionals of the segment.

Deadline

Please make the time sensitivity of this bug report clear with a date that it should be completed by. If there is no specific date, then the task will be triaged based on its priority.

This is tech debt and has no explicit deadline


Information below this point is filled out by the task assignee.

Assignee Planning

Sub Tasks

A full breakdown of the steps to complete this task.

  • Find all conditionals that are overly verbose and contain logically impossible clauses
  • Simplify these for the queries for the segmentation DAG as well as the exploration notebook to clean up prior work for example code

Estimation

Estimate: Half a day
Actual:

Notes

Things that came up during the completion of this task, questions to be answered and follow up tasks.

  • Note