Page MenuHomePhabricator

Open Citation Dialog when editing template main content from a subref
Closed, ResolvedPublic

Description

User story

GIVEN I'm editing a page in VE
AND there's a sub-ref that adds details to a main ref that includes a Citation template (e.g. cite_book)

<ref details="page 1">{{cite_book|first=Ben|last=Miller}}</ref>

WHEN I open the context menu item
AND click the edit button on the main content
THEN the Citation Dialog should open to edit the main content

Background

The context menu is different on nodes that identify as citations that include a citation template. The Edit button there triggers something else.

It might make sense to create a context menu item that works for both and merge the two.

Event Timeline

Change #1151175 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Fix to allow opening the CitationDialog from subrefs

https://gerrit.wikimedia.org/r/1151175

Change #1151175 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Fix to allow opening the CitationDialog from subrefs

https://gerrit.wikimedia.org/r/1151175

Sorry I just discovered, that my patch has one problem:

  • It opens the template dialog
  • BUT: Loads the details content into it and saves back to the details content ^^'

Change #1151677 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Add fragment to all types of command

https://gerrit.wikimedia.org/r/1151677

Change #1151677 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Add fragment to all types of command

https://gerrit.wikimedia.org/r/1151677

awight moved this task from Doing to Demo on the WMDE-TechWish-Sprint-2025-05-28 board.