Change #1151776 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@master] Stop relying on Xml::input

https://gerrit.wikimedia.org/r/1151776

I had trouble getting the form to be shown locally (you know... flaggedrevs...) so the patch is not really tested.

Can try this if you want: T394403#10825958

Or I'll just load it up and test it and +2 it in a moment :)

edit: Never mind, different form than I was thinking. I remembered there was some Xml left in Stabilization.php, but looks like your patch is for RejectConfirmationFormUI.php

In T395357#10865506, @Ladsgroup wrote:

I had trouble getting the form to be shown locally (you know... flaggedrevs...) so the patch is not really tested.

I noticed. :( Actually, it’s easy to get the form once one knows how to:

1. Have a page with pending changes.
2. Make the review form appear (e.g. Review… in the popup shown by the Pending indicator).
3. Click Reject changes.
4. The page that loads uses this form.

This has been one of the noisier things in logspam-watch for a while now.

Change #1151776 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Stop relying on Xml::input

https://gerrit.wikimedia.org/r/1151776

This is now the most prominent error in logspam-watch.

A patch to fix this merged on Thursday. Do you think that patch will solve the error when it rides the train?

On a side note, I wonder if we should be porting things like Xml:inputLabel() to the Html class to make these easier to mass refactor.

In T395357#10920087, @Novem_Linguae wrote:

A patch to fix this merged on Thursday. Do you think that patch will solve the error when it rides the train?

I haven't looked at the patch, but knowing that something will roll out this week is comforting. Thanks!