Page MenuHomePhabricator

strange recursive behaviour
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

image.png (969×624 px, 66 KB)

  • Then disconnect the code implementations, and reload the page and make sure tests have completed running. Now the recursive composition appears to pass almost all tests (the fail is a timeout):

image.png (985×858 px, 79 KB)

What happens?:
The success of the recursive implementation seems to depend on the connection status of the JS function.

What should have happened instead?:
Although it is expected that when enabled the JS will be used for inner calls of the recursion, if the JS is working correctly (as the other tests say it is), then the results of those inner calls should be correct, so the outer call result should also be correct. Hence all tests *should* pass on the composition no matter whether the JS is connected or not.

Event Timeline

There are similar failures in the recursive implementation at https://www.wikifunctions.org/view/en/Z16643. It seems to be getting a 0 returned from the sub-calls (to the JS implementation).

I found this when investigating https://phabricator.wikimedia.org/T395464, which I think shares a common source.

Slack-bot changed the task status from Open to In Progress.Jul 3 2025, 2:34 PM
Slack-bot closed this task as Resolved.

The tests are now all passing when all implementations are connected. I don't know about the underlying issues, but on the surface this appears fixed.

Ah! Okay, I'll resolve it for now. We can re-open it if this symptom reappears at some point.

Ah! Yes, I meant to do that. Closed.