Page MenuHomePhabricator
Create Task
Maniphest T395470

Drop deprecated phpunit.php and suite.xml
Open, Needs TriagePublic
Actions

Description

The old tests/phpunit/phpunit.php entrypoint and its associates tests/phpunit/suite.xml configuration file have been deprecated as part of T90875 and some parts were removed via T227900. Developers should now use composer phpunit (or vendor/bin/phpunit directly), and phpunit.xml.dist if they need to do something explicitly with the config file. This task tracks the removal of both, as well associated functionality, from MW core.

To do:

  • Direct usages in CI (codesearch). Some of these might were kept around for REL1_39, where vendor/bin/phpunit was not yet a viable replacement, but that is now EOL.
    • quibble-coverage scripts in integration/config.git
    • Use in integration/quibble.git
      • Dropped
      • Released
  • Usages in WMF extensions/skins (codesearch)
  • MW core cleanup (codesearch). Also anything referenced by these, like dropping bootstrap.maintenance.php, and merging bootstrap.common.php and bootstrap.integration.php.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
jjb: Bump quibble-coverage: Direct PHPUnit, include Dump/ParserFuzz/Stubintegration/configmaster+3 -3
Docker: [quibble-coverage] Stop using legacy PHPUnit entrypointintegration/configmaster+15 -15
jjb: [mwcore-phpunit-coverage-patch] Invoke PHPUnit directlyintegration/configmaster+1 -1
Always use `composer phpunit` for PHPUnit testsintegration/quibblemaster+23 -18
README: Update instructions for running testsmediawiki/extensions/Scoremaster+2 -2
Remove deprecated PHPUnit entry point, config, and bootstrapmediawiki/coremaster+10 -350
jjb: [mwcore-phpunit-coverage-patch] Stop using legacy PHPUnit entrypointintegration/configmaster+1 -1
tests: add skins to PHPUnit "extensions:unit" test suitemediawiki/coreREL1_44+4 -13
tests: add skins to PHPUnit "extensions:unit" test suitemediawiki/coreREL1_43+4 -13
tests: add skins to PHPUnit "extensions:unit" test suitemediawiki/coreREL1_39+1 -0
tests: add skins to PHPUnit "extensions" test suitemediawiki/coremaster+3 -11
zuul: switch skins coverage to same job as extensionsintegration/configmaster+1 -1
jjb: switch skins coverage to mwext-phpunit-coverageintegration/configmaster+1 -1
quibble-bullseye-php81-coverage: Fix bad `--path-to-mw` argintegration/configmaster+7 -1
quibble-coverage: Fix `--path-to-mw` arg for skinsintegration/configmaster+7 -1
tests: Drop ancient bootstrap.phpmediawiki/extensions/MobileFrontendmaster+0 -18
Update PHPUnit command in run-mediawiki-testsmediawiki/vagrantmaster+1 -1
Update PHPUnit command in Makefile, take 2mediawiki/extensions/UniversalLanguageSelectormaster+1 -1
Update PHPUnit command in Makefile and documentationmediawiki/extensions/CirrusSearchmaster+2 -2
Update PHPUnit command in Makefilemediawiki/extensions/ContentTranslationmaster+2 -2
Update PHPUnit command in Makefilemediawiki/extensions/Elasticamaster+1 -5
Avoid comment reference to deprecated suite.xmlmediawiki/tools/phpunit-patch-coveragemaster+1 -1
Update PHPUnit command in Makefilemediawiki/extensions/GeoDatamaster+1 -1
jjb: Update mwext-*-coverage* jobs to quibble-bullseye-php81-coverage:1.14.2-s2integration/configmaster+3 -3
Update PHPUnit command in Makefilemediawiki/extensions/UniversalLanguageSelectormaster+2 -2
Update PHPUnit command in Makefilemediawiki/extensions/TranslationNotificationsmaster+1 -1
Update PHPUnit command in Makefilemediawiki/extensions/cldrmaster+1 -1
tests: Drop ancient PHPUnit setupmediawiki/extensions/Flowmaster+1 -48
mwext-phpunit-coverage: Switch from legacy phpunit.php to vendor/bin/phpunitintegration/configmaster+16 -12
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
 OpenNoneT50217 Speed up MediaWiki PHPUnit build by running integration tests in parallel
 OpenNoneT395470 Drop deprecated phpunit.php and suite.xml
 ResolvedReedyT403199 Formally EOL MW 1.39
 ResolvedReedyT404610 Release MediaWiki 1.39.16/1.43.6/1.44.3/1.45.1
Restricted Task
Restricted Task
Restricted Task
Restricted Task
Restricted Task
Restricted Task
Restricted Task
Restricted Task
Restricted Task
Restricted Task
Restricted Task
 ResolvedAtienoT401987 Consider deprecating/removing the xslt option from the action api
Restricted Task
Restricted Task
Restricted Task
Restricted Task
Restricted Task
Restricted Task
 ResolvedNoneT404617 Update onwiki release notes for 1.39.16/1.43.6/1.44.3/1.45.1
Restricted Task
 ResolvedZabeT404619 Update HISTORY in master after 1.39.16/1.43.6/1.44.3/1.45.1
 ResolvedmmartoranaT404620 Write and send supplementary release announcement for extensions and skins with security patches (1.39.16/1.43.6/1.44.3/1.45.1)
 ResolvedReedyT412854 Release 1.39.17
 ResolvedDaimonaT90875 Use vendor/bin/phpunit instead of tests/phpunit/phpunit.php
 ResolvedkostajhT297292 Fix "Deprecated: Premature access to service" from data providers when using vendor/bin/phpunit
 ResolvedDaimonaT227900 Phase out usage of tests/phpunit/suite.xml
 ResolveddanielT304183 Allow LocalSettings.php to be loaded in a function scope
 ResolvedBUG REPORTkostajhT306020 PHPUnit integration tests fail with "No such service: HookContainer"

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2025, 3:40 PM
Daimona updated the task description. (Show Details)May 28 2025, 3:45 PM
Jdforrester-WMF added a project: Technical-Debt.May 28 2025, 3:46 PM
Jdforrester-WMF awarded a token.
Jdforrester-WMF moved this task from Unsorted to Cleanup on the Technical-Debt board.
Jdforrester-WMF subscribed.
Daimona updated the task description. (Show Details)Jun 26 2025, 5:00 PM
gerritbot added a comment.Aug 8 2025, 7:54 PM

Change #1176721 had a related patch set uploaded (by Krinkle; author: Krinkle):

[integration/config@master] mwext-phpunit-coverage: Switch from legacy phpunit.php to vendor/bin/phpunit

https://gerrit.wikimedia.org/r/1176721

gerritbot added a project: Patch-For-Review.Aug 8 2025, 7:54 PM
gerritbot added a comment.Aug 12 2025, 4:34 PM

Change #1176721 merged by jenkins-bot:

[integration/config@master] mwext-phpunit-coverage: Switch from legacy phpunit.php to vendor/bin/phpunit

https://gerrit.wikimedia.org/r/1176721

gerritbot added a comment.Aug 12 2025, 4:39 PM

Change #1178034 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/MobileFrontend@master] tests: Drop ancient bootstrap.php

https://gerrit.wikimedia.org/r/1178034

gerritbot added a comment.Aug 12 2025, 4:52 PM

Change #1178037 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Flow@master] tests: Drop ancient PHPUnit setup

https://gerrit.wikimedia.org/r/1178037

gerritbot added a comment.Aug 12 2025, 4:59 PM

Change #1178039 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/cldr@master] Update PHPUnit command in Makefile

https://gerrit.wikimedia.org/r/1178039

gerritbot added a comment.Aug 12 2025, 5:02 PM

Change #1178040 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/UniversalLanguageSelector@master] Update PHPUnit command in Makefile

https://gerrit.wikimedia.org/r/1178040

gerritbot added a comment.Aug 12 2025, 5:04 PM

Change #1178041 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/TranslationNotifications@master] Update PHPUnit command in Makefile

https://gerrit.wikimedia.org/r/1178041

gerritbot added a comment.Aug 12 2025, 5:06 PM

Change #1178042 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/GeoData@master] Update PHPUnit command in Makefile

https://gerrit.wikimedia.org/r/1178042

gerritbot added a comment.Aug 12 2025, 5:08 PM

Change #1178044 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Elastica@master] Update PHPUnit command in Makefile

https://gerrit.wikimedia.org/r/1178044

gerritbot added a comment.Aug 12 2025, 5:09 PM

Change #1178045 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/ContentTranslation@master] Update PHPUnit command in Makefile

https://gerrit.wikimedia.org/r/1178045

gerritbot added a comment.Aug 12 2025, 5:11 PM

Change #1178046 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CirrusSearch@master] Update PHPUnit command in Makefile and documentation

https://gerrit.wikimedia.org/r/1178046

gerritbot added a comment.Aug 12 2025, 5:13 PM

Change #1178047 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/vagrant@master] Update PHPUnit command in run-mediawiki-tests

https://gerrit.wikimedia.org/r/1178047

gerritbot added a comment.Aug 12 2025, 5:18 PM

Change #1178048 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/tools/phpunit-patch-coverage@master] Avoid comment reference to deprecated suite.xml

https://gerrit.wikimedia.org/r/1178048

Daimona added a comment.Aug 12 2025, 5:19 PM

I made patches for all extensions, as well as development tools (plus a couple cleanup patches for things that were accidentally included in the codesearch, not tagged with this task). The only remaining thing is CI config, once that's also done we can drop the old stuff and clean up.

gerritbot added a comment.Aug 12 2025, 6:11 PM

Change #1178037 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] tests: Drop ancient PHPUnit setup

https://gerrit.wikimedia.org/r/1178037

gerritbot added a comment.Aug 12 2025, 6:35 PM

Change #1178039 merged by jenkins-bot:

[mediawiki/extensions/cldr@master] Update PHPUnit command in Makefile

https://gerrit.wikimedia.org/r/1178039

gerritbot added a comment.Aug 12 2025, 6:35 PM

Change #1178040 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Update PHPUnit command in Makefile

https://gerrit.wikimedia.org/r/1178040

gerritbot added a comment.Aug 12 2025, 6:35 PM

Change #1178041 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Update PHPUnit command in Makefile

https://gerrit.wikimedia.org/r/1178041

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.15; 2025-08-19).Aug 12 2025, 7:00 PM
gerritbot added a comment.Aug 12 2025, 8:20 PM

Change #1178071 had a related patch set uploaded (by Krinkle; author: Krinkle):

[integration/config@master] quibble-bullseye-php81-coverage: Fix bad `--path-to-mw` arg

https://gerrit.wikimedia.org/r/1178071

gerritbot added a comment.Aug 12 2025, 8:21 PM

Change #1178030 had a related patch set uploaded (by Krinkle; author: Krinkle):

[integration/config@master] jjb: Update mwext-*-coverage* jobs to quibble-bullseye-php81-coverage:1.14.2-s1

https://gerrit.wikimedia.org/r/1178030

gerritbot added a comment.Aug 12 2025, 8:51 PM

Change #1178071 merged by jenkins-bot:

[integration/config@master] quibble-bullseye-php81-coverage: Fix bad `--path-to-mw` arg

https://gerrit.wikimedia.org/r/1178071

gerritbot added a comment.Aug 12 2025, 9:02 PM

Change #1178030 merged by jenkins-bot:

[integration/config@master] jjb: Update mwext-*-coverage* jobs to quibble-bullseye-php81-coverage:1.14.2-s2

https://gerrit.wikimedia.org/r/1178030

Krinkle updated the task description. (Show Details)Aug 12 2025, 9:14 PM
gerritbot added a comment.Aug 12 2025, 9:26 PM

Change #1178042 merged by jenkins-bot:

[mediawiki/extensions/GeoData@master] Update PHPUnit command in Makefile

https://gerrit.wikimedia.org/r/1178042

gerritbot added a comment.Aug 13 2025, 9:49 AM

Change #1178048 merged by jenkins-bot:

[mediawiki/tools/phpunit-patch-coverage@master] Avoid comment reference to deprecated suite.xml

https://gerrit.wikimedia.org/r/1178048

gerritbot added a comment.Aug 13 2025, 10:21 AM

Change #1178044 merged by jenkins-bot:

[mediawiki/extensions/Elastica@master] Update PHPUnit command in Makefile

https://gerrit.wikimedia.org/r/1178044

gerritbot added a comment.Aug 13 2025, 10:21 AM

Change #1178045 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Update PHPUnit command in Makefile

https://gerrit.wikimedia.org/r/1178045

gerritbot added a comment.Aug 13 2025, 10:21 AM

Change #1178046 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Update PHPUnit command in Makefile and documentation

https://gerrit.wikimedia.org/r/1178046

gerritbot added a comment.Aug 13 2025, 11:21 AM

Change #1178511 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/UniversalLanguageSelector@master] Update PHPUnit command in Makefile, take 2

https://gerrit.wikimedia.org/r/1178511

gerritbot added a comment.Aug 13 2025, 1:44 PM

Change #1178511 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Update PHPUnit command in Makefile, take 2

https://gerrit.wikimedia.org/r/1178511

gerritbot added a comment.Aug 18 2025, 11:38 PM

Change #1178034 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/MobileFrontend@master] tests: Drop ancient bootstrap.php

https://gerrit.wikimedia.org/r/1178034

gerritbot added a comment.Aug 18 2025, 11:41 PM

Change #1178047 merged by Daimona Eaytoy:

[mediawiki/vagrant@master] Update PHPUnit command in run-mediawiki-tests

https://gerrit.wikimedia.org/r/1178047

gerritbot added a comment.Aug 19 2025, 3:07 AM

Change #1178034 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] tests: Drop ancient bootstrap.php

https://gerrit.wikimedia.org/r/1178034

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.16; 2025-08-26); removed MW-1.45-notes (1.45.0-wmf.15; 2025-08-19).Aug 19 2025, 4:00 AM
Daimona updated the task description. (Show Details)Aug 19 2025, 10:31 AM
gerritbot added a comment.Aug 20 2025, 5:22 PM

Change #1180606 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] quibble-coverage: Fix `--path-to-mw` arg for skins

https://gerrit.wikimedia.org/r/1180606

gerritbot added a comment.Aug 21 2025, 6:38 AM

Change #1180606 abandoned by Hashar:

[integration/config@master] quibble-coverage: Fix `--path-to-mw` arg for skins

Reason:

Per Timo, it is a bit more complicated :)

https://gerrit.wikimedia.org/r/1180606

Jdforrester-WMF added a subtask: T403199: Formally EOL MW 1.39.Aug 28 2025, 5:05 PM
hashar subscribed.Aug 29 2025, 8:24 AM
hashar added a subscriber: Krinkle.Sep 4 2025, 2:10 PM
In T395470#11071207, @gerritbot wrote:

Change #1176721 had a related patch set uploaded (by Krinkle; author: @Krinkle):

[integration/config@master] mwext-phpunit-coverage: Switch from legacy phpunit.php to vendor/bin/phpunit

https://gerrit.wikimedia.org/r/1176721

We need the same patch for the mwskin-phpunit-coverage or alternatively move skins to use the same jobs (mwext-phpunit-coverage and mwext-phpunit-coverage-publish). The later will let us phase out the last mwskin prefixed jobs and fulfill T402398.

gerritbot added a comment.Sep 8 2025, 12:09 PM

Change #1185862 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/core@master] tests: add skins to PHPUnit "extensions" test suite

https://gerrit.wikimedia.org/r/1185862

gerritbot added a comment.Sep 8 2025, 1:08 PM

Change #1185925 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: switch skins coverage to mwext-phpunit-coverage

https://gerrit.wikimedia.org/r/1185925

gerritbot added a comment.Sep 8 2025, 1:10 PM

Change #1185926 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] zuul: switch skins coverage to same job as extensions

https://gerrit.wikimedia.org/r/1185926

gerritbot added a comment.Sep 8 2025, 2:06 PM

Change #1185862 merged by jenkins-bot:

[mediawiki/core@master] tests: add skins to PHPUnit "extensions" test suite

https://gerrit.wikimedia.org/r/1185862

gerritbot added a comment.Sep 9 2025, 7:30 AM

Change #1185925 merged by jenkins-bot:

[integration/config@master] jjb: switch skins coverage to mwext-phpunit-coverage

https://gerrit.wikimedia.org/r/1185925

gerritbot added a comment.Sep 9 2025, 7:30 AM

Change #1185926 merged by jenkins-bot:

[integration/config@master] zuul: switch skins coverage to same job as extensions

https://gerrit.wikimedia.org/r/1185926

hashar mentioned this in T227900: Phase out usage of tests/phpunit/suite.xml.Sep 9 2025, 8:22 AM
hashar updated the task description. (Show Details)
gerritbot added a comment.Sep 9 2025, 8:37 AM

Change #1186436 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/core@REL1_39] tests: add skins to PHPUnit "extensions" test suite

https://gerrit.wikimedia.org/r/1186436

gerritbot added a comment.Sep 9 2025, 8:44 AM

Change #1186440 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/core@REL1_43] tests: add skins to PHPUnit "extensions" test suite

https://gerrit.wikimedia.org/r/1186440

gerritbot added a comment.Sep 9 2025, 8:47 AM

Change #1186441 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/core@REL1_44] tests: add skins to PHPUnit "extensions" test suite

https://gerrit.wikimedia.org/r/1186441

Daimona added a comment.Sep 12 2025, 12:45 PM

Remaining usages in CI are in quibble-bullseye-php81-coverage and mwcore-phpunit-coverage-patch; presumably both simple updates? Then removing the old syntax from phpunit-suite-edit.py and updating some comments. I think the usages in quibble need to stay for 1.39 but can be cleaned up later this year.

gerritbot added a comment.Sep 17 2025, 12:56 AM

Change #1186436 merged by jenkins-bot:

[mediawiki/core@REL1_39] tests: add skins to PHPUnit "extensions:unit" test suite

https://gerrit.wikimedia.org/r/1186436

gerritbot added a comment.Sep 17 2025, 1:03 AM

Change #1186440 merged by jenkins-bot:

[mediawiki/core@REL1_43] tests: add skins to PHPUnit "extensions:unit" test suite

https://gerrit.wikimedia.org/r/1186440

gerritbot added a comment.Sep 17 2025, 1:03 AM

Change #1186441 merged by jenkins-bot:

[mediawiki/core@REL1_44] tests: add skins to PHPUnit "extensions:unit" test suite

https://gerrit.wikimedia.org/r/1186441

Daimona updated the task description. (Show Details)Oct 7 2025, 12:42 PM
Daimona added a project: User-Daimona.
Reedy mentioned this in T407878: CI noise in mwext-phpunit-coverage-patch.Oct 21 2025, 9:39 PM
Reedy changed the status of subtask T403199: Formally EOL MW 1.39 from Open to In Progress.Dec 16 2025, 6:31 PM
Jdforrester-WMF closed subtask T403199: Formally EOL MW 1.39 as Resolved.Mon, Jan 5, 1:40 PM
Daimona updated the task description. (Show Details)Mon, Jan 5, 5:47 PM
Jdforrester-WMF added a comment.Mon, Jan 5, 6:09 PM

OK, this should now finally be fully unblocked, AIUI?

Daimona added a comment.Mon, Jan 5, 7:15 PM
In T395470#11493280, @Jdforrester-WMF wrote:

OK, this should now finally be fully unblocked, AIUI?

Correct. The CI cleanup needs to happen first and I think I wasn't completely sure about a couple places; there's also some extra cleanup like removal of the --path-to-mw option. Then the MW core part should be straightforward.

gerritbot added a comment.Wed, Jan 14, 10:38 PM

Change #1226955 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: [mwcore-phpunit-coverage-patch] Switch from legacy PHPUnit entrypoint to composer

https://gerrit.wikimedia.org/r/1226955

gerritbot added a comment.Wed, Jan 14, 10:54 PM

Change #1226955 merged by jenkins-bot:

[integration/config@master] jjb: [mwcore-phpunit-coverage-patch] Stop using legacy PHPUnit entrypoint

https://gerrit.wikimedia.org/r/1226955

Jdforrester-WMF added a comment.Wed, Jan 14, 10:54 PM
In T395470#11493671, @Daimona wrote:
In T395470#11493280, @Jdforrester-WMF wrote:

OK, this should now finally be fully unblocked, AIUI?

Correct. The CI cleanup needs to happen first and I think I wasn't completely sure about a couple places; there's also some extra cleanup like removal of the --path-to-mw option. Then the MW core part should be straightforward.

I've done the easy one, mwcore-phpunit-coverage-patch, which was defined inline. I'll have a poke at the other four (mwext-phpunit-coverage-patch, mwext-phpunit-coverage, mwext-phpunit-coverage-publish, mwcore-phpunit-coverage-master) later if I have time.

Jdforrester-WMF added subtasks: T90875: Use vendor/bin/phpunit instead of tests/phpunit/phpunit.php, T227900: Phase out usage of tests/phpunit/suite.xml.Wed, Jan 14, 10:56 PM
gerritbot added a comment.Wed, Jan 21, 10:25 PM

Change #1229739 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[integration/quibble@master] Always use `composer phpunit` for PHPUnit tests

https://gerrit.wikimedia.org/r/1229739

gerritbot added a comment.Wed, Jan 21, 10:38 PM

Change #1229756 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[integration/config@master] dockerfiles: Drop legacy PHPUnit entrypoint from quibble-coverage

https://gerrit.wikimedia.org/r/1229756

Daimona added a comment.Wed, Jan 21, 10:41 PM
In T395470#11523366, @Jdforrester-WMF wrote:
In T395470#11493671, @Daimona wrote:
In T395470#11493280, @Jdforrester-WMF wrote:

OK, this should now finally be fully unblocked, AIUI?

Correct. The CI cleanup needs to happen first and I think I wasn't completely sure about a couple places; there's also some extra cleanup like removal of the --path-to-mw option. Then the MW core part should be straightforward.

I've done the easy one, mwcore-phpunit-coverage-patch, which was defined inline. I'll have a poke at the other four (mwext-phpunit-coverage-patch, mwext-phpunit-coverage, mwext-phpunit-coverage-publish, mwcore-phpunit-coverage-master) later if I have time.

Thanks! I made patches for quibble and quibble-coverage. It seemed easy enough, but then I don't know if it actually works. Patch for core coming next.

gerritbot added a comment.Wed, Jan 21, 10:42 PM

Change #1229764 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Score@master] README: Update instructions for running tests

https://gerrit.wikimedia.org/r/1229764

gerritbot added a comment.Wed, Jan 21, 10:55 PM

Change #1229777 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Remove deprecated PHPUnit entry point, config, and bootstrap

https://gerrit.wikimedia.org/r/1229777

gerritbot added a comment.Thu, Jan 22, 12:09 AM

Change #1229764 merged by jenkins-bot:

[mediawiki/extensions/Score@master] README: Update instructions for running tests

https://gerrit.wikimedia.org/r/1229764

Daimona added a comment.Thu, Jan 22, 2:30 PM

For mwcore-phpunit-coverage-patch, I just randomly opened a build and noticed that it fails due to the 5m timeout of composer. Switching to the direct invocation should fix that.

gerritbot added a comment.Thu, Jan 22, 2:33 PM

Change #1229739 merged by jenkins-bot:

[integration/quibble@master] Always use `composer phpunit` for PHPUnit tests

https://gerrit.wikimedia.org/r/1229739

gerritbot added a comment.Thu, Jan 22, 2:33 PM

Change #1230350 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[integration/config@master] jjb: [mwcore-phpunit-coverage-patch] Invoke PHPUnit directly

https://gerrit.wikimedia.org/r/1230350

gerritbot added a comment.Thu, Jan 22, 2:45 PM

Change #1230350 merged by jenkins-bot:

[integration/config@master] jjb: [mwcore-phpunit-coverage-patch] Invoke PHPUnit directly

https://gerrit.wikimedia.org/r/1230350

gerritbot added a comment.Thu, Jan 22, 5:33 PM

Change #1229756 merged by jenkins-bot:

[integration/config@master] Docker: [quibble-coverage] Stop using legacy PHPUnit entrypoint

https://gerrit.wikimedia.org/r/1229756

Stashbot added a comment.Thu, Jan 22, 5:36 PM

Mentioned in SAL (#wikimedia-releng) [2026-01-22T17:36:18Z] <James_F> Docker: [quibble-coverage] Stop using legacy PHPUnit entrypoint (T395470) & Stop excluding Dump/ParserFuzz/Stub groups (T415230)

Stashbot mentioned this in T415230: Remove default PHPUnit exclusion of "Dump", "ParserFuzz", and "Stub" groups.Thu, Jan 22, 5:36 PM
gerritbot added a comment.Thu, Jan 22, 5:42 PM

Change #1230404 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: Bump quibble-coverage: Direct PHPUnit, incclude Dump/ParserFuzz/Stub

https://gerrit.wikimedia.org/r/1230404

Jdforrester-WMF updated the task description. (Show Details)Thu, Jan 22, 5:49 PM
gerritbot added a comment.Thu, Jan 22, 5:50 PM

Change #1230404 merged by jenkins-bot:

[integration/config@master] jjb: Bump quibble-coverage: Direct PHPUnit, include Dump/ParserFuzz/Stub

https://gerrit.wikimedia.org/r/1230404

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits