Page MenuHomePhabricator
Create Task
Maniphest T395483

LogicException: CentralAuth authentication is needed but not available
Closed, ResolvedPublic
Actions

Description

Seen on an unrelated ConfirmEdit patch - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ConfirmEdit/+/1151737

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php81/5115/console

17:07:20 1) MediaWiki\CheckUser\Tests\Integration\GlobalContributions\CheckUserApiRequestAggregatorTest::testExecuteAuthenticateCentralAuth
17:07:20 LogicException: CentralAuth authentication is needed but not available
17:07:20 
17:07:20 /workspace/src/extensions/CheckUser/src/GlobalContributions/CheckUserApiRequestAggregator.php:84
17:07:20 /workspace/src/extensions/CheckUser/tests/phpunit/integration/GlobalContributions/CheckUserApiRequestAggregatorTest.php:141
17:07:20 
17:07:20 2) MediaWiki\CheckUser\Tests\Integration\GlobalContributions\SpecialGlobalContributionsTest::testLinksToHelpPage
17:07:20 LogicException: CentralAuth authentication is needed but not available
17:07:20 
17:07:20 /workspace/src/extensions/CheckUser/src/GlobalContributions/CheckUserApiRequestAggregator.php:84
17:07:20 /workspace/src/extensions/CheckUser/src/GlobalContributions/GlobalContributionsPager.php:165
17:07:20 /workspace/src/extensions/CheckUser/src/GlobalContributions/GlobalContributionsPager.php:206
17:07:20 /workspace/src/extensions/CheckUser/src/GlobalContributions/GlobalContributionsPager.php:300
17:07:20 /workspace/src/includes/pager/IndexPager.php:289
17:07:20 /workspace/src/extensions/CheckUser/src/GlobalContributions/GlobalContributionsPager.php:274
17:07:20 /workspace/src/includes/pager/IndexPager.php:578
17:07:20 /workspace/src/includes/specialpage/ContributionsSpecialPage.php:377
17:07:20 /workspace/src/includes/poolcounter/PoolCounterWorkViaCallback.php:81
17:07:20 /workspace/src/includes/poolcounter/PoolCounterWork.php:173
17:07:20 /workspace/src/includes/specialpage/ContributionsSpecialPage.php:397
17:07:20 /workspace/src/extensions/CheckUser/src/GlobalContributions/SpecialGlobalContributions.php:112
17:07:20 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:124
17:07:20 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:53
17:07:20 /workspace/src/tests/phpunit/includes/specials/SpecialPageTestBase.php:76
17:07:20 /workspace/src/extensions/CheckUser/tests/phpunit/integration/GlobalContributions/SpecialGlobalContributionsTest.php:677

Similar to T381429: Visiting Special:GlobalContributions/<target> without CentralAuth loaded results in a LogicException, but now in CI...

See also: T395485: LoginNotifyTest::testRecordFailureKnownCheckUser Number of jobs executed must be at least 1 as appearing at the same time.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert "phpunit: Delay initial TestSetup config to after extension registration"mediawiki/coreREL1_44+14 -3
Revert "phpunit: Delay initial TestSetup config to after extension registration"mediawiki/coremaster+14 -3
Revert "phpunit: Delay initial TestSetup config to after extension registration"mediawiki/coreREL1_44+14 -3
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.May 28 2025, 4:09 PM
Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptMay 28 2025, 4:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy triaged this task as High priority.May 28 2025, 4:39 PM
Reedy raised the priority of this task from High to Unbreak Now!.
Reedy updated the task description. (Show Details)
Reedy mentioned this in T395485: LoginNotifyTest::testRecordFailureKnownCheckUser Number of jobs executed must be at least 1.
bvibber subscribed.May 28 2025, 4:59 PM

Seen same on a JsonConfig patch, doesn't seem to be related to our code: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php81/5141/console

bvibber added a comment.May 28 2025, 5:17 PM

Any chance these could be related to recent changes in CentralAuth and core for CA-related testing?

gerritbot added a comment.May 28 2025, 5:21 PM

Change #1151762 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Revert "phpunit: Delay initial TestSetup config to after extension registration"

https://gerrit.wikimedia.org/r/1151762

gerritbot added a project: Patch-For-Review.May 28 2025, 5:21 PM
gerritbot added a comment.May 28 2025, 5:52 PM

Change #1151767 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@REL1_44] Revert "phpunit: Delay initial TestSetup config to after extension registration"

https://gerrit.wikimedia.org/r/1151767

Daimona mentioned this in T277470: Ignore (most) of LocalSettings.php when running PHPUnit (fix surprise test failures).May 28 2025, 5:53 PM
gerritbot added a comment.May 28 2025, 5:56 PM

Change #1151768 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@REL1_44] Revert "phpunit: Delay initial TestSetup config to after extension registration"

https://gerrit.wikimedia.org/r/1151768

gerritbot added a comment.May 28 2025, 5:57 PM

Change #1151768 abandoned by Jforrester:

[mediawiki/core@REL1_44] Revert "phpunit: Delay initial TestSetup config to after extension registration"

Reason:

Let's go with I9668dd72b3e87443de6bae05369e267ba0538c63 then.

https://gerrit.wikimedia.org/r/1151768

gerritbot added a comment.May 28 2025, 6:00 PM

Change #1151767 merged by jenkins-bot:

[mediawiki/core@REL1_44] Revert "phpunit: Delay initial TestSetup config to after extension registration"

https://gerrit.wikimedia.org/r/1151767

ReleaseTaggerBot added a project: MW-1.44-notes.May 28 2025, 6:00 PM
Novem_Linguae subscribed.May 28 2025, 6:04 PM
gerritbot added a comment.May 28 2025, 6:06 PM

Change #1151762 merged by jenkins-bot:

[mediawiki/core@master] Revert "phpunit: Delay initial TestSetup config to after extension registration"

https://gerrit.wikimedia.org/r/1151762

Daimona closed this task as Resolved.May 28 2025, 6:09 PM
Daimona claimed this task.
Daimona subscribed.

This should now be fixed. Discussion of the original patch can continue in T277470. Apologies for the breakage!

Reedy merged a task: T395485: LoginNotifyTest::testRecordFailureKnownCheckUser Number of jobs executed must be at least 1.May 28 2025, 6:25 PM
Reedy added a subscriber: taavi.
Maintenance_bot removed a project: Patch-For-Review.May 28 2025, 6:30 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.4; 2025-06-03).May 28 2025, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits