Page MenuHomePhabricator
Create Task
Maniphest T395494

MetricsPlatform dependency is causing CI to fail on older (yet supported) MediaWiki release branches (REL1_39, REL1_42)
Closed, ResolvedPublic
Actions

Description

Example change sets:

  1. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TwoColConflict/+/1151262
  2. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TwoColConflict/+/1151261

Affected CI jobs:

  1. quibble-composer-mysql-php81
  2. quibble-composer-mysql-php81-selenium

Sample jenkins error output:

10:55:43 * A dependency error was encountered while installing the extension "MetricsPlatform": MetricsPlatform is not compatible with the current MediaWiki core (version 1.39.12), it requires: >= 1.44.
10:55:43 MetricsPlatform requires EventStreamConfig to be installed.
10:55:43 MetricsPlatform requires EventLogging to be installed.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ext.wikimediaEvents: Soft-depend on MetricsPlatformmediawiki/extensions/WikimediaEventswmf/1.45.0-wmf.3+10 -9
ext.wikimediaEvents: Soft-depend on MetricsPlatformmediawiki/extensions/WikimediaEventsmaster+10 -9
Revert "Zuul: [mediawiki/extensions/WikimediaEvents] Add MetricsPlatform dependency"integration/configmaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

sbassett created this task.May 28 2025, 5:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2025, 5:18 PM
sbassett added a project: Metrics Platform.May 28 2025, 5:18 PM
Jdforrester-WMF added subscribers: hashar, Jdforrester-WMF.May 28 2025, 6:02 PM

Probably caused by f257b92c553d7c52d196569e7562635c2c6b08b9 deployed yesterday, but there's no CI run for old branches from before that was landed for me to confirm.

CC @hashar @pheudx

sbassett added a subscriber: phuedx.May 28 2025, 6:04 PM
Krinkle subscribed.May 28 2025, 6:16 PM

This is in part due to T389998: Allow control over which extra extensions are installed (Math REL1_43 jobs exceed 60min timeout).

dependencies.yaml
TwoColConflict:
 - BetaFeatures
 - EventLogging
 - WikiEditor

Interestingly, the dependency chain does not cross through EventLogging.

TwoColConflict soft-depends and choses to integrate with WikiEditor, where WikiEditor's own patches normally integrate with WikimediaEvents, which in turn then choses to integrate with WikimediaEvents, which then pulls in MetricsPlatform.

phuedx added a comment.May 30 2025, 11:53 AM
In T395494#10865213, @Jdforrester-WMF wrote:

Probably caused by f257b92c553d7c52d196569e7562635c2c6b08b9 deployed yesterday, but there's no CI run for old branches from before that was landed for me to confirm.

CC @hashar @pheudx

Happy to back out that change and make the very-much-temporary code in WikimediaEvents soft depend on MetricsPlatform.

phuedx added a comment.May 30 2025, 12:06 PM

I also considered adding a dependency on EventStreamConfigs as MetricsPlatform has a hard dependency on that (whereas EventLogging only has a soft dependency on it) but doubtless there are other dependency chains like @Krinkle detailed above and, as I said, the code is a short-live experiment/instrument.

gerritbot added a comment.May 30 2025, 12:57 PM

Change #1152259 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/WikimediaEvents@master] ext.wikimediaEvents: Soft-depend on MetricsPlatform

https://gerrit.wikimedia.org/r/1152259

gerritbot added a project: Patch-For-Review.May 30 2025, 12:57 PM

Change #1152260 had a related patch set uploaded (by Phuedx; author: Phuedx):

[integration/config@master] Revert "Zuul: [mediawiki/extensions/WikimediaEvents] Add MetricsPlatform dependency"

https://gerrit.wikimedia.org/r/1152260

gerritbot added a comment.May 30 2025, 1:35 PM

Change #1152260 merged by jenkins-bot:

[integration/config@master] Revert "Zuul: [mediawiki/extensions/WikimediaEvents] Add MetricsPlatform dependency"

https://gerrit.wikimedia.org/r/1152260

Lucas_Werkmeister_WMDE mentioned this in T395684: CI error: mediawiki.base/track trackError: unexpected "{\"exception\":{},\"source\":\"resolve\"}".May 30 2025, 2:59 PM
gerritbot added a comment.May 30 2025, 3:28 PM

Change #1152259 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] ext.wikimediaEvents: Soft-depend on MetricsPlatform

https://gerrit.wikimedia.org/r/1152259

Maintenance_bot removed a project: Patch-For-Review.May 30 2025, 3:30 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.4; 2025-06-03).May 30 2025, 4:00 PM
gerritbot added a comment.May 30 2025, 8:12 PM

Change #1152349 had a related patch set uploaded (by BryanDavis; author: Phuedx):

[mediawiki/extensions/WikimediaEvents@wmf/1.45.0-wmf.3] ext.wikimediaEvents: Soft-depend on MetricsPlatform

https://gerrit.wikimedia.org/r/1152349

gerritbot added a project: Patch-For-Review.May 30 2025, 8:12 PM
gerritbot added a comment.May 30 2025, 8:38 PM

Change #1152349 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@wmf/1.45.0-wmf.3] ext.wikimediaEvents: Soft-depend on MetricsPlatform

https://gerrit.wikimedia.org/r/1152349

Stashbot added a comment.May 30 2025, 8:38 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-30T20:38:37Z] <bd808@deploy1003> Started scap sync-world: Backport for [[gerrit:1152349|ext.wikimediaEvents: Soft-depend on MetricsPlatform (T395684 T395494)]], [[gerrit:1152346|Revert "JCCache: Use WANObjectCache::getWithSetCallback() instead of set/get" (T395368)]]

Stashbot mentioned this in T395368: PHP Warning: Attempt to read property "fields" on null.May 30 2025, 8:38 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-30T20:40:37Z] <bd808@deploy1003> bd808, bvibber: Backport for [[gerrit:1152349|ext.wikimediaEvents: Soft-depend on MetricsPlatform (T395684 T395494)]], [[gerrit:1152346|Revert "JCCache: Use WANObjectCache::getWithSetCallback() instead of set/get" (T395368)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.May 30 2025, 8:48 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-30T20:48:37Z] <bd808@deploy1003> Finished scap sync-world: Backport for [[gerrit:1152349|ext.wikimediaEvents: Soft-depend on MetricsPlatform (T395684 T395494)]], [[gerrit:1152346|Revert "JCCache: Use WANObjectCache::getWithSetCallback() instead of set/get" (T395368)]] (duration: 09m 59s)

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.3; 2025-05-27); removed MW-1.45-notes (1.45.0-wmf.4; 2025-06-03).May 30 2025, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 30 2025, 9:30 PM
phuedx closed this task as Resolved.Aug 13 2025, 1:10 PM
phuedx claimed this task.

Being bold

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits