Page MenuHomePhabricator

Bookmark button breaks on Vector responsive design
Open, Stalled, MediumPublicBUG REPORT

Description

NOTE: Blocked on {T365631?}. Tracking task only.

Steps to replicate the issue (include links if applicable):

  • Use the Vector 2022 skin with the Reading Lists beta feature enabled
  • Click the bookmark icon and observe the proper functionality
  • Resize your browser window to any width less than 640px
  • Bookmark icon disappears (it is replaced with a text-only link)
  • Click the Add/remove bookmark link in Tools dropdown menu

What happens?:

The dropdown closes, but nothing else happens.

What should have happened instead?:

  • A notification should appear, indicating the page was successfully added or removed.
  • The button's text should change from "Add bookmark" to "Remove bookmark" (or vice-versa)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

The current bookmark code expects only one bookmark button on the page. It is not able to detect clicks or update the text-based link, due to it being a child of a completely different element.

SCR-20250529-oyus.png (1×1 px, 459 KB)

SCR-20250529-ozra.png (1×1 px, 389 KB)

SCR-20250529-pbxw.png (1×1 px, 347 KB)

Event Timeline

@JScherer-WMF previously discussed that it would be preferable to do T365631: Redesign Vector 2022 header and actions for mobile devices so this will remain a bug until we do that.

SToyofuku-WMF changed the task status from Open to Stalled.May 29 2025, 11:36 PM
SToyofuku-WMF subscribed.

Blocked on T365631?

If this is blocked on T365631, then T365631 should be a subtask of this (and not a parent task), shouldn’t it?