AddRedLinks causes OOMs in Parsoid on some pages
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ssastry
	May 29 2025, 10:42 PM

Description

See analysis in T392261#10869596

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Bump wikimedia/parsoid to 0.22.0-a8	mediawiki/vendor	master	+288 -300
Avoid ZhConverter creation altogether in AddRedLinks	mediawiki/services/parsoid	master	+11 -6
Bump wikimedia/parsoid to 0.22.0-a5	mediawiki/vendor	master	+762 -678
Create language converter only once for AddRedLinks	mediawiki/services/parsoid	master	+34 -27

Customize query in gerrit

Related Objects

Mentioned In: T400140: Existed links render as redlinks in Template
Mentioned Here: T392261: Investigate crashers (out of memory, timeouts)

Event Timeline

ssastry created this task.May 29 2025, 10:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2025, 10:42 PM

ihurbain claimed this task.May 30 2025, 2:09 PM

From my analysis, this is a compound "languageconverter + addredlinks" issue. The redlink addition ends up repeatedly creating a language converter for the current page language, and SOMEHOW it leaks - it's unclear to me why it wouldn't get swept away at the end of the method execution (*maybe* static method???), but in any case it's also fairly inefficient to re-create it in the first place.

Change #1152286 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Create language converter only once for AddRedLinks

https://gerrit.wikimedia.org/r/1152286

gerritbot added a project: Patch-For-Review.May 30 2025, 3:03 PM

ihurbain moved this task from Backlog to Code Review on the Content-Transform-Team (Work In Progress) board.May 30 2025, 4:31 PM

Change #1152286 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Create language converter only once for AddRedLinks

https://gerrit.wikimedia.org/r/1152286

Maintenance_bot removed a project: Patch-For-Review.May 30 2025, 5:31 PM

ihurbain moved this task from Code Review to To Deploy on the Content-Transform-Team (Work In Progress) board.Jun 2 2025, 3:11 PM

Change #1152766 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a5

https://gerrit.wikimedia.org/r/1152766

gerritbot added a project: Patch-For-Review.Jun 2 2025, 3:46 PM

Change #1152766 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a5

https://gerrit.wikimedia.org/r/1152766

Maintenance_bot removed a project: Patch-For-Review.Jun 2 2025, 6:30 PM

MSantos moved this task from Needs Triage to Performance on the Parsoid board.Jun 5 2025, 2:12 PM

ihurbain closed this task as Resolved.Jun 13 2025, 11:55 AM

Change #1160189 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Avoid ZhConverter creation altogether in AddRedLinks

https://gerrit.wikimedia.org/r/1160189

gerritbot added a project: Patch-For-Review.Jun 17 2025, 4:07 PM

Change #1160189 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Avoid ZhConverter creation altogether in AddRedLinks

https://gerrit.wikimedia.org/r/1160189

Maintenance_bot removed a project: Patch-For-Review.Jun 17 2025, 9:30 PM

Change #1162965 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a8

https://gerrit.wikimedia.org/r/1162965

gerritbot added a project: Patch-For-Review.Jun 23 2025, 4:26 PM

Change #1162965 merged by jenkins-bot: