Page MenuHomePhabricator

Remove MobileFrontend and Minerva search code post-deployment of new mobile typeahead search
Closed, ResolvedPublic3 Estimated Story Points

Description

Background

Following the deploy we can remove 7kb of compressed JavaScript from initial page load on mobile and delete over a 1000 lines of unused code.

User story

As a user I don't want to load unused unmaintained code in my mobile experience.

Requirements

BDD

Feature: Mobile search uses core TypeaheadSearch without legacy Minerva/MobileFrontend search code

  Scenario: Mobile search works at standard viewport
    Given I am on a mobile wiki page
    When I focus the search input
    Then typeahead search suggestions are shown and are usable

  Scenario: Mobile search works at narrower viewport with search icon affordance
    Given I am on a mobile wiki page at a lower resolution where a search icon is shown
    When I tap the search icon
    Then the search field focuses and typeahead search suggestions are shown and are usable

  Scenario: No legacy Minerva search overlay behavior
    Given the new TypeaheadSearch is active
    When I interact with search
    Then no Minerva-specific search overlay UI appears

  Scenario: Watchlist features remain functional
    Given I have items in my watchlist
    When I view Watchlist and use watch/unwatch controls
    Then watchlist renders correctly and watchstars function as expected

  Scenario: No visual regressions versus production
    Given I compare the updated mobile experience to production
    When I use search and browse common pages
    Then the UI matches production behavior and appearance

Test Steps

Test Case 1: Verify mobile search at standard viewport

  1. Open any article on the mobile site (Minerva skin).
  2. Focus the search input.
  3. AC1: Typeahead suggestions appear and update as you type.
  4. AC2: Selecting a suggestion navigates correctly.
  5. AC3: No Minerva legacy search overlay appears (UI is Codex/core TAHS).

Test Case 2: Verify mobile search at lower resolution with search icon

  1. Resize/emulate a narrower mobile viewport where a search icon is shown.
  2. Click/tap the search icon.
  3. AC4: The search field focuses and the suggestions panel opens.
  4. AC5: Suggestions behave correctly (navigate with touch/keyboard, select, navigate).
  5. AC6: No legacy search overlay behavior appears.

Test Case 3: Validate watchlist remains functional

  1. Ensure AMC is disabled in settings.
  2. Go to Special:EditWatchlist/raw and add several pages.
  3. Visit Special:Watchlist.
  4. If needed, click “View and edit watchlist” tab.
  5. AC7: Watchlist loads and displays items as expected.
  6. AC8: Watch/unwatch (watchstar) controls work (state updates on click, persists on refresh).

Test Case 4: Compare against production for regressions

  1. In one window, open the updated beta/mobile site; in another, open production/mobile for the same pages.
  2. Exercise search (focus, type, select), page navigation, and watchstars on both.
  3. AC9: No visual or behavioral regressions versus production for mobile search and general UX.

QA Results - Beta

QA Results - Prod

Design

  • Add mockups and design requirements

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Event Timeline

Change #1152180 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Drop the TypeaheadSearch feature flag and make it default

https://gerrit.wikimedia.org/r/1152180

Change #1138811 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] WIP: Drop MobileFrontend search code

https://gerrit.wikimedia.org/r/1138811

Jdlrobson-WMF renamed this task from Remove MobileFrontend search code post-deployment of new mobile typeahead search to Remove MobileFrontend and Minerva search code post-deployment of new mobile typeahead search.May 30 2025, 7:33 PM
Jdlrobson-WMF added a project: MinervaNeue.
Jdlrobson changed the task status from Open to In Progress.May 30 2025, 9:22 PM
Jdlrobson moved this task from Incoming to Q4 on the Web-Team board.
Jdlrobson-WMF set the point value for this task to 3.Jun 2 2025, 5:43 PM
Jdlrobson-WMF changed the task status from In Progress to Open.Jun 2 2025, 5:52 PM

Change #1159542 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[operations/mediawiki-config@master] Enable new mobile search experience everywhere (not including empty search recommendations)

https://gerrit.wikimedia.org/r/1159542

Change #1174485 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/Wikibase@master] Remove enabled check for Minerva TAHS search module replacement

https://gerrit.wikimedia.org/r/1174485

Change #1152180 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Drop the TypeaheadSearch feature flag and make it default

https://gerrit.wikimedia.org/r/1152180

Change #1138811 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Drop MobileFrontend search code

https://gerrit.wikimedia.org/r/1138811

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS / ❓Need More Info
Environment: beta
OS: macOS Sequoia 15.5
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: NA

Test Case 1: Verify mobile search at standard viewport

  1. Open any article on the mobile site (Minerva skin).
  2. Focus the search input.
  3. AC1: Typeahead suggestions appear and update as you type.
  4. AC2: Selecting a suggestion navigates correctly.
  5. AC3: No Minerva legacy search overlay appears (UI is Codex/core TAHS).

screenshot 1.mov.gif (1×1 px, 1 MB)

screenshot 27.png (1×1 px, 517 KB)

Test Case 2: Verify mobile search at lower resolution with search icon

  1. Resize/emulate a narrower mobile viewport where a search icon is shown.
  2. Click/tap the search icon.
  3. AC4: The search field focuses and the suggestions panel opens.
  4. AC5: Suggestions behave correctly (navigate with touch/keyboard, select, navigate).
  5. AC6: No legacy search overlay behavior appears.

screenshot.mov.gif (932×428 px, 446 KB)

screenshot 26.png (1×1 px, 156 KB)

Test Case 3: Validate watchlist remains functional

  1. Ensure AMC is disabled in settings.
  2. Go to Special:EditWatchlist/raw and add several pages.
  3. Visit Special:Watchlist.
  4. If needed, click “View and edit watchlist” tab.
  5. AC7: Watchlist loads and displays items as expected.
  6. AC8: Watch/unwatch (watchstar) controls work (state updates on click, persists on refresh).

@bwang, I'm not sure if the text watch/unwatch is supposed to be there. It is in Prod as well. The text does go away upon refresh.

screenshot 3.mov.gif (1×1 px, 1 MB)

Test Case 4: Compare against production for regressions

  1. In one window, open the updated beta/mobile site; in another, open production/mobile for the same pages.
  2. Exercise search (focus, type, select), page navigation, and watchstars on both.
  3. AC9: No visual or behavioral regressions versus production for mobile search and general UX.

screenshot 4.mov.gif (1×1 px, 698 KB)

Jdrewniak subscribed.

I'll create a follow-up task to address the watchlist label + icon issue.

I'll create a follow-up task to address the watchlist label + icon issue.

@Jdrewniak did you create this?

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sequoia 15.5
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: NA

Test Case 1: Verify mobile search at standard viewport

  1. Open any article on the mobile site (Minerva skin).
  2. Focus the search input.
  3. AC1: Typeahead suggestions appear and update as you type.
  4. AC2: Selecting a suggestion navigates correctly.
  5. AC3: No Minerva legacy search overlay appears (UI is Codex/core TAHS).

screenshot 43.png (1×1 px, 596 KB)

screenshot 5.mov.gif (930×1 px, 1 MB)

Test Case 2: Verify mobile search at lower resolution with search icon

  1. Resize/emulate a narrower mobile viewport where a search icon is shown.
  2. Click/tap the search icon.
  3. AC4: The search field focuses and the suggestions panel opens.
  4. AC5: Suggestions behave correctly (navigate with touch/keyboard, select, navigate).
  5. AC6: No legacy search overlay behavior appears.

screenshot 6.mov.gif (1×682 px, 691 KB)

Test Case 3: Validate watchlist remains functional

  1. Ensure AMC is disabled in settings.
  2. Go to Special:EditWatchlist/raw and add several pages.
  3. Visit Special:Watchlist.
  4. If needed, click “View and edit watchlist” tab.
  5. AC7: Watchlist loads and displays items as expected.
  6. AC8: Watch/unwatch (watchstar) controls work (state updates on click, persists on refresh).

AC8 is supposed to be addressed in a different task per T395634#11079087

Test Case 4: Compare against production for regressions

  1. In one window, open the updated beta/mobile site; in another, open production/mobile for the same pages.
  2. Exercise search (focus, type, select), page navigation, and watchstars on both.

3.✅ AC9: No visual or behavioral regressions versus production for mobile search and general UX.
This is a production deployment validation test so comparing it to the screenshot shown in AC9 of T395634#11076546 you can see they are the same.