Page MenuHomePhabricator

[batch #1] Enable revertrisk filters in simplewiki & trwiki
Closed, ResolvedPublic

Description

The ORES extension is already installed in simplewiki and trwiki and we now want to add the revertrisk filter that is using the language agnostic revertrisk model.

Steps to enable the filters on simplewiki and trwiki

Extension:

  • Update any i18n system messages :

https://translatewiki.net/w/i.php?title=Special%3ATranslate&group=ext-ores-user&language=tr&action_source=search&filter=&optional=1&action=translate

MediaWiki-Config:

  • Add revertrisk model to the list of models enabled for simplewiki and trwiki and deploy the change

Define the models that are going to be used for id wiki by adding an idwiki entry in the wgOresModels var.
Here we should make sure we don't disable the models that are already enabled on these wikis (damaging and goodfaith)
Backfill

  • Run backfill job
mwscript-k8s --comment="T382171" -- extensions/ORES/maintenance/PopulateDatabase.php --wiki=idwiki

Event Timeline

Change #1151693 had a related patch set uploaded (by Gkyziridis; author: Gkyziridis):

[operations/mediawiki-config@master] ores-extension: enable ores extension for rrla without UI for simplewiki and trwiki

https://gerrit.wikimedia.org/r/1151693

isarantopoulos renamed this task from Enable revertrisk filters in simplewiki & trwiki to Enable revertrisk filters in simplewiki & trwiki [batch #1].Jun 2 2025, 4:09 PM
isarantopoulos renamed this task from Enable revertrisk filters in simplewiki & trwiki [batch #1] to [batch #1] Enable revertrisk filters in simplewiki & trwiki .Jun 3 2025, 1:09 PM

Change #1151693 abandoned by Gkyziridis:

[operations/mediawiki-config@master] ores-extension: enable revertrisk filter for simplewiki and trwiki

Reason:

It is merged into this: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1155604

https://gerrit.wikimedia.org/r/1151693

I merged the patch for trwiki and simplewiki into the patch for batch#2 where we are at the final stage enabling the UI in this patch which is scheduled for backport deployment tomorrow at 1:00 UTC time

Change #1155604 had a related patch set uploaded (by Ilias Sarantopoulos; author: Gkyziridis):

[operations/mediawiki-config@master] ores-extension: enable oresUI for the second batch of wikis

https://gerrit.wikimedia.org/r/1155604

Change #1155604 merged by jenkins-bot:

[operations/mediawiki-config@master] ores-extension: enable oresUI for the second batch of wikis

https://gerrit.wikimedia.org/r/1155604

Mentioned in SAL (#wikimedia-operations) [2025-06-12T13:04:06Z] <gkyziridis@deploy1003> Started scap sync-world: Backport for [[gerrit:1155604|ores-extension: enable oresUI for the second batch of wikis (T395823 T395668)]]

Mentioned in SAL (#wikimedia-operations) [2025-06-12T13:06:16Z] <gkyziridis@deploy1003> gkyziridis: Backport for [[gerrit:1155604|ores-extension: enable oresUI for the second batch of wikis (T395823 T395668)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

There was an issue during the deployment for simplewiki and trwiki which resulted in errors. We experienced some errors during the sync in the test servers (here is the list of errors in logstash from mw-debug) which resulted in the rest of the ores extension filters to disappear so we didnt proceed with this deployment.
For complete reference this is the error message

	Error in ChangesListHookHandler: No model available for [revertrisklanguageagnostic]

We also saw that the model didn't end up in the ores_model table of the database which happens when scores are fetched.

I think that this error would go away after the first request to the model is made. During the first request if the model+version is not found a new entry will be inserted in the ores_model table (link to relevant code) so after that the filters would work normally.
However we should investigate why the rest of the filters weren't showing up in this case.

I have replicated locally the above behavior and the following things happen:

  1. revertrisk filter is enabled
  2. model doesn't exist in the ores_model table
  3. filters do not show in recentchanges page at all
  4. after first successful request to the model an row for the new model is inserted in the ores_model table and all filters (old and new ones) show up as expected.

Change #1170092 had a related patch set uploaded (by Gkyziridis; author: Gkyziridis):

[operations/mediawiki-config@master] ores-extension: enable revertrisk filter for simplewiki and trwiki

https://gerrit.wikimedia.org/r/1170092

Change #1170092 merged by jenkins-bot:

[operations/mediawiki-config@master] ores-extension: enable revertrisk filter for simplewiki and trwiki

https://gerrit.wikimedia.org/r/1170092

Mentioned in SAL (#wikimedia-operations) [2025-07-17T07:03:06Z] <gkyziridis@deploy1003> Started scap sync-world: Backport for [[gerrit:1170092|ores-extension: enable revertrisk filter for simplewiki and trwiki (T395668)]]

Mentioned in SAL (#wikimedia-operations) [2025-07-17T07:05:41Z] <gkyziridis@deploy1003> gkyziridis: Backport for [[gerrit:1170092|ores-extension: enable revertrisk filter for simplewiki and trwiki (T395668)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-07-17T07:16:31Z] <gkyziridis@deploy1003> Finished scap sync-world: Backport for [[gerrit:1170092|ores-extension: enable revertrisk filter for simplewiki and trwiki (T395668)]] (duration: 13m 25s)