Page MenuHomePhabricator

UniversalLanguageSelector loads Vue on page load unnecessarily
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Visit any page making sure UniversalLanguageSelector extension is not installed
  • Check if Vue is loaded on the page via mw.loader.getState('vue');
  • Enable UniversalLanguageSelector extension
  • Check if Vue is loaded on the page via mw.loader.getState('vue');

What happens?:
Vue gets unnecessarily loaded on page load by ULS.

What should have happened instead?:
There is no need to load it since ULS only depends on styles in Vue.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change #1152350 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Don't load Vue on page load

https://gerrit.wikimedia.org/r/1152350

Change #1152370 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ContentTranslation@master] Add bundle size checks for other modules loaded on page load.

https://gerrit.wikimedia.org/r/1152370

Change #1152350 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Don't load Vue on page load

https://gerrit.wikimedia.org/r/1152350

Change #1152370 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Add bundle size checks for other modules loaded on page load.

https://gerrit.wikimedia.org/r/1152370

Thanks all. I am only seeing vue on page loads when a QuickSurvey is active now. Thanks for working on this!