Page MenuHomePhabricator
Create Task
Maniphest T395804

captcha.py: Gracefully handle output dir not existing
Closed, ResolvedPublic
Actions

Description

reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/extensions/ConfirmEdit$ python3 captcha.py --wordlist=~/words --badwordlist=~/badwords --key='foo' --output=/tmp/captchas --font=/usr/share/fonts/truetype/freefont/FreeMonoBoldOblique.ttf --verbose --fill=1000
Traceback (most recent call last):
  File "/var/www/wiki/mediawiki/extensions/ConfirmEdit/captcha.py", line 436, in <module>
    count = max(0, fill - len(os.listdir(output)))
                              ^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/captchas'
reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/extensions/ConfirmEdit$ mkdir /tmp/captchas

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
captcha.py: Check if output dir exists, and attempt to create it (else error)mediawiki/extensions/ConfirmEditwmf/1.45.0-wmf.3+6 -0
captcha.py: Check if output dir exists, and attempt to create it (else error)mediawiki/extensions/ConfirmEditREL1_43+6 -0
captcha.py: Check if output dir exists, and attempt to create it (else error)mediawiki/extensions/ConfirmEditREL1_44+6 -0
captcha.py: Check if output dir exists, and attempt to create it (else error)mediawiki/extensions/ConfirmEditmaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Jun 2 2025, 1:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2025, 1:48 PM
Reedy triaged this task as Low priority.Jun 2 2025, 1:48 PM
• Clement_Goubert subscribed.Jun 2 2025, 2:43 PM

The behaviour is inconsistent between specifying --fill and not:

python3 /srv/mediawiki/php-1.45.0-wmf.3/extensions/ConfirmEdit/captcha.py --wordlist=/tmp/words --badwordlist=/tmp/badwords --key='foo' --output=/tmp/captchas --font=/usr/share/fonts/truetype/dejavu/DejaVuSans.ttf --verbose --fill=1000
Traceback (most recent call last):
  File "/srv/mediawiki/php-1.45.0-wmf.3/extensions/ConfirmEdit/captcha.py", line 421, in <module>
    count = max(0, fill - len(os.listdir(output)))
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/captchas'
www-data@b386d95fae9d:/$ python3 /srv/mediawiki/php-1.45.0-wmf.3/extensions/ConfirmEdit/captcha.py --wordlist=/tmp/words --badwordlist=/tmp/badwords --key='foo' --output=/tmp/captchas --font=/usr/share/fonts/truetype/dejavu/DejaVuSans.ttf --verbose 
Generating 20 CAPTCHA images separated in 20 image(s) per chunk run by 1 threads...
[...]
image_a3336939_ad9b6da10e44bb26.png
gerritbot added a comment.Jun 2 2025, 2:45 PM

Change #1152753 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmEdit@master] captcha.py: Check if output dir exists, and attempt to create it (else error)

https://gerrit.wikimedia.org/r/1152753

gerritbot added a project: Patch-For-Review.Jun 2 2025, 2:45 PM
Reedy added a comment.Jun 2 2025, 2:46 PM

^ Just do some checking when we grab the option

Reedy moved this task from Backlog to Bugs on the ConfirmEdit (CAPTCHA extension) board.Jun 2 2025, 2:51 PM
Krinkle closed this task as Resolved.Jun 2 2025, 6:05 PM
Krinkle assigned this task to Reedy.
Krinkle added projects: Sustainability (Incident Followup), Security-Team.
Krinkle subscribed.

Hardening after captcha incident on June 2, 2025, ref T388531#10875132.

gerritbot added a comment.Jun 2 2025, 6:48 PM

Change #1152753 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] captcha.py: Check if output dir exists, and attempt to create it (else error)

https://gerrit.wikimedia.org/r/1152753

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.4; 2025-06-03).Jun 2 2025, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 2 2025, 7:31 PM
gerritbot added a comment.Jun 2 2025, 9:00 PM

Change #1152821 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmEdit@REL1_43] captcha.py: Check if output dir exists, and attempt to create it (else error)

https://gerrit.wikimedia.org/r/1152821

gerritbot added a project: Patch-For-Review.Jun 2 2025, 9:00 PM

Change #1152822 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmEdit@REL1_44] captcha.py: Check if output dir exists, and attempt to create it (else error)

https://gerrit.wikimedia.org/r/1152822

gerritbot added a comment.Jun 2 2025, 9:15 PM

Change #1152822 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@REL1_44] captcha.py: Check if output dir exists, and attempt to create it (else error)

https://gerrit.wikimedia.org/r/1152822

gerritbot added a comment.Jun 2 2025, 9:18 PM

Change #1152821 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@REL1_43] captcha.py: Check if output dir exists, and attempt to create it (else error)

https://gerrit.wikimedia.org/r/1152821

Maintenance_bot removed a project: Patch-For-Review.Jun 2 2025, 9:31 PM
gerritbot added a comment.Jun 4 2025, 11:51 AM

Change #1153593 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmEdit@wmf/1.45.0-wmf.3] captcha.py: Check if output dir exists, and attempt to create it (else error)

https://gerrit.wikimedia.org/r/1153593

gerritbot added a project: Patch-For-Review.Jun 4 2025, 11:51 AM
gerritbot added a comment.Jun 4 2025, 12:04 PM

Change #1153593 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@wmf/1.45.0-wmf.3] captcha.py: Check if output dir exists, and attempt to create it (else error)

https://gerrit.wikimedia.org/r/1153593

Stashbot added a comment.Jun 4 2025, 12:18 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-04T12:18:22Z] <reedy@deploy1003> Started scap sync-world: Backport for [[gerrit:rLPRI1153591423f9|GenerateFancyCaptchas: Handle captcha.py not generating any captchas, but not erroring (T388531)]], [[gerrit:1153592|captcha.py: Expand variables and user in filenames (T395810)]], [[gerrit:1153593|captcha.py: Check if output dir exists, and attempt to create it (else error) (T395804)]], [[gerrit:1153595|captcha.py: Bail out if no words were read

Stashbot mentioned this in T388531: Migrate Security-Team jobs to mw-cron.Jun 4 2025, 12:18 PM
Stashbot mentioned this in T395810: captcha.py: Doesn't like use of ~/filename.
Stashbot added a comment.Jun 4 2025, 12:20 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-04T12:20:31Z] <reedy@deploy1003> reedy: Backport for [[gerrit:rLPRI1153591423f9|GenerateFancyCaptchas: Handle captcha.py not generating any captchas, but not erroring (T388531)]], [[gerrit:1153592|captcha.py: Expand variables and user in filenames (T395810)]], [[gerrit:1153593|captcha.py: Check if output dir exists, and attempt to create it (else error) (T395804)]], [[gerrit:1153595|captcha.py: Bail out if no words were read from wordlist (T3

Stashbot mentioned this in T3: Upgrade logstash elasticsearch instance to latest version.Jun 4 2025, 12:20 PM
Stashbot added a comment.Jun 4 2025, 12:28 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-04T12:28:13Z] <reedy@deploy1003> Finished scap sync-world: Backport for [[gerrit:rLPRI1153591423f9|GenerateFancyCaptchas: Handle captcha.py not generating any captchas, but not erroring (T388531)]], [[gerrit:1153592|captcha.py: Expand variables and user in filenames (T395810)]], [[gerrit:1153593|captcha.py: Check if output dir exists, and attempt to create it (else error) (T395804)]], [[gerrit:1153595|captcha.py: Bail out if no words were rea

Maintenance_bot removed a project: Patch-For-Review.Jun 4 2025, 12:31 PM
ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.3; 2025-05-27); removed MW-1.45-notes (1.45.0-wmf.4; 2025-06-03).Jun 4 2025, 1:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits