ebomani opened https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/160

Updating Patchdemo wikis table using Codex CSS only.

ebomani opened https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/162

Draft: Implementing Patchdemo multi-delete MVP

Talked to some codex folks. Pulling in codex for CSS only requires manually adding a lot of classes, which fights how codex is meant to work with vue components handling css/css class add/remove transitions. As a result, we're not planning to use codex for this change.

For more context regarding our decision to not use codex for this change, here are some notes from my talks with Codex folks :

"Beyond maybe re-using a few colour tokens I'm not sure there's a lot of benefit in converting just that table to Codex - the rest of the app still uses OOUI pretty heavily (and it would be very complex to convert). You'll probably just end up loading both UI libraries indefinitely.
Note also that most of the complexity in the Patchdemo table are the styles implement sticky headers, and that make it responsive (on mobile devices the rows convert to cards) "

and

if you are trying to generate markup for complex Codex components like tables, and you're trying to do it in PHP, I'd recommend looking into the following approaches: consider using a template language (twig, mustache, etc) – might make the code much easier to follow and maintain
use Codex PHP, a (still experimental) PHP composer package that can programmatically produce Codex-compatible markup for CSS-only components

From these comments, it seems our decision to go the Codex CSS only route might not be the best bet. Although we still want to Codexify our front-end we do have to plan out the right way to go about implementation since the PHP is still experimental and the CSS only implementation requires further tweaking to make functional.

Our decision to do the Codex CSS only route was driven by the thought that it would be a relatively straight-forward addition in order to improve our UI and get us closer to the eventual goal of it being fully Codex, which we have determined to not quite be the case from my implementation attempts and the discussions with the Codex team.

jhuneidi opened https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/170

Correct rebase of multi-delete branch

jhuneidi closed https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/162

Implementing Patchdemo multi-delete MVP

jhuneidi merged https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/170

Correct rebase of multi-delete branch

ebomani opened https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/175

Fix Multi-delete UI

ebomani opened https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/176

Implementation of Patch demo Multi-delete + Fix

ebomani closed https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/175

Fix Multi-delete UI

ebomani merged https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/176

Implementation of Patch demo Multi-delete + Fix

Thanks for the work that's been done on this! :)
A few notes from some things I noticed with the new UI elements (let me know if you'd like me to file any/all of these as separate tasks!):

1) At the moment, it seems like the checkboxes are slightly vertically-misaligned with the linked wiki-IDs. It also feels (IMO) like there could be a little bit of extra padding added to the right of each checkbox, before each wiki's ID:

2) When scrolling down the page, the checkboxes overlap the sticky table headers at the top of the page:

3) When hovering over the "Delete selected" link, it doesn't become underlined, which makes it feel different from the other links on the page/less like a link:

comparing this (hovering over the linked wiki ID)	to this (hovering over the "Delete selected" link)

4) My browser's developer tools complains to me that the checkbox elements don't have labels. (I don't know whether or not this presents any issues within the UI, but I thought it might be worth noting):

esanders closed https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/160

Updating Patchdemo wikis table using Codex CSS only.