Found during deployment of T377975: Enable template favouriting on Beta, pilot wikis, and test, decided to continue with deployment and fix after
Steps to replicate the issue (include links if applicable):
- Go to https://www.mediawiki.org/w/index.php?title=User:TheresNoTime-WMF
- Click edit, and open the template selection dialog
- Click categories
- Select a template from the list of templates
What happens?:
Uncaught Error: Invalid pageId: undefined
at parsePageId (load.php?lang=en&modules=ext.CodeMirror.v6%7Cext.CodeMirror.v6.lib%7Cext.templateData.templateDiscovery%7Cjquery%2Coojs-ui-core%7Cjquery.ui%7Cmediawiki.base&skin=vector&version=16fzz:661:865)
at FavoritesStore.js.FavoritesStore.isFavorite (load.php?lang=en&modules=ext.CodeMirror.v6%7Cext.CodeMirror.v6.lib%7Cext.templateData.templateDiscovery%7Cjquery%2Coojs-ui-core%7Cjquery.ui%7Cmediawiki.base&skin=vector&version=16fzz:662:909)
at new FavoriteButton (load.php?lang=en&modules=ext.CodeMirror.v6%7Cext.CodeMirror.v6.lib%7Cext.templateData.templateDiscovery%7Cjquery%2Coojs-ui-core%7Cjquery.ui%7Cmediawiki.base&skin=vector&version=16fzz:664:266)
at new MWTemplateWizardTemplateTitleBar (ext.TemplateWizard.TemplateTitleBar.js:31:26)
at mw.TemplateWizard.TemplateForm.getForm (ext.TemplateWizard.TemplateForm.js:71:26)
at new MWTemplateWizardTemplateForm (ext.TemplateWizard.TemplateForm.js:24:27)
at mw.TemplateWizard.Dialog.showTemplate (ext.TemplateWizard.Dialog.js:97:22)
at OO.EventEmitter.emit (oojs.js:858:12)
at TemplateSearchLayout.js.TemplateSearchLayout.onAddTemplate (load.php?lang=en&modules=ext.CodeMirror.v6%7Cext.CodeMirror.v6.lib%7Cext.templateData.templateDiscovery%7Cjquery%2Coojs-ui-core%7Cjquery.ui%7Cmediawiki.base&skin=vector&version=16fzz:649:636)
at OO.EventEmitter.emit (oojs.js:858:12)What should have happened instead?:
Template should have been selected, and the dialog progressed to the next screen
Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
- nb selecting a favourited template works correctly
