hi @Sarai-WMF - would you mind validating the following?

Per comment on original MR, can you verify what needs to change for the spacing of fields in that User traffic per wiki field set?

In T396045#10885704, @cjming wrote:

hi @Sarai-WMF - would you mind validating the following?

Per comment on original MR, can you verify what needs to change for the spacing of fields in that User traffic per wiki field set?

The spacing between the rows of fields included in the User traffic per wiki module should be 16px (spacing-100):

https://gitlab.wikimedia.org/repos/data-engineering/mpic/-/merge_requests/188

phuedx merged https://gitlab.wikimedia.org/repos/data-engineering/mpic/-/merge_requests/188

Minor fixes to forms

a few more MRs are in flight so we can deploy them together to staging for QA/design review - will post back here when ready

Hey @cjming. There's a small layout issue that I only detected now. I'm not sure what's causing it, but the wiki fields are not horizontally aligned with their corresponding traffic fields and delete buttons:

For some reason, the 'All wikis' field isn't affected by this 🤔

hi @Sarai-WMF - i actually saw this and pushed a fix for it in https://gitlab.wikimedia.org/repos/data-engineering/mpic/-/merge_requests/188 which we will push to staging shortly for your review -- thanks for the call out! i surprised myself that I even noticed it - subtle stuff like this usually eludes my radar

Change #1155328 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/deployment-charts@master] xLab: Deploy v0.6.8 release to staging

https://gerrit.wikimedia.org/r/1155328

Change #1155328 merged by jenkins-bot:

[operations/deployment-charts@master] xLab: Deploy v0.6.8 release to staging

https://gerrit.wikimedia.org/r/1155328

Hey @cjming! Things are looking great: thank you for the fixes 🙏🏻
All ACs appear to have been covered, and I only found an outsandlind issue that we can very well document and decide to tackle later:

In the 'User traffic per wiki' field, options that don't correspond to wikis (like user groups) are still being displayed by the 'Wiki' field menu:

Just fyi, I created a placeholder ticket to update the copy of the validation confirmation dialog once we know for certain which fields from the 'Traffic and variations' section won't be editable once an experiment is turned on: T396578: xLab: Update copy of activation confirmation dialog

hi @Sarai-WMF - re: excluding some wikis -- there are ~8 wikis with "User Group" in their English name. One thing I noticed for ease of filtering is that their editablity is set to private while their visibility === public (this designation is also relevant for fishbowl wikis -- we also already filter out wikis with visibility === private).

Here's a short list from the tsv that we pull from for wikis with editability === private and visibility === public which amounts to 19 wikis and includes the user groups you noted:

Wikimedians of United Arab Emirates User Group
Wikimedia Armenia
Azerbaijani Wikimedians User Group
Wikimedia China
Donate
Wikimedia Community User Group Georgia
Wikimedia Community User Group Greece
Hindi Wikimedians User Group
Wikimedia Indonesia
Maithili Wikimedians User Group
Wikimedia Nigeria
Nostalgia Wikipedia
Punjabi Wikimedians
Wikimedians of Romania and Moldova User Group
Wikimedia Serbia
Thank you
Wikimedia Venezuela
Wikimedia Vote
West Bengal Wikimedians User Group

The easiest filter would be filter out on an existing field like editability (I can look into parsing names to limit the filter to wikis with english names that have User Group in the title) which would remove the 19 wikis from the chip input select -- does that seem reasonable?

Or do you want to just filter out the ones with User Group in their english names which is ~8 wikis?

Re: validation copy ticket - thanks!

In T396045#10918800, @cjming wrote:

The easiest filter would be filter out on an existing field like editability (I can look into parsing names to limit the filter to wikis with english names that have User Group in the title) which would remove the 19 wikis from the chip input select -- does that seem reasonable?

Or do you want to just filter out the ones with User Group in their english names which is ~8 wikis?

Thanks for looking into this, Clare! I would tentatively agree to filter out those 19 sites based on private editability, to improve the relevance of the wiki menu options. I wouldn't expect that teams will have a need to experiment on user group pages and what I assume are project pages in meta. Nevertheless, I believe it'd be cautious to validate this with @JVanderhoop-WMF 🙏🏻

I think that sounds good @Sarai-WMF @cjming and if we do get to that point in the future, we can always consider how we might add the capability in a way that scales.

sfaci merged https://gitlab.wikimedia.org/repos/data-engineering/mpic/-/merge_requests/200

Update wikis to filter out private editability

Change #1162089 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/deployment-charts@master] xLab: Deploy v0.7.2 release to staging

https://gerrit.wikimedia.org/r/1162089

Change #1162089 merged by jenkins-bot:

[operations/deployment-charts@master] xLab: Deploy v0.7.2 release to staging

https://gerrit.wikimedia.org/r/1162089

hi @Sarai-WMF - the latest change (filtering out editability === private from the wikis list) is up on staging for your review.

Thank you, @cjming! All outstanding issues appear to be resolved, and no additional design-related problems were detected at this time 💯

Change #1165182 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/deployment-charts@master] xLab: Deploy v0.7.5 release to production

https://gerrit.wikimedia.org/r/1165182

Change #1165182 merged by jenkins-bot:

[operations/deployment-charts@master] xLab: Deploy v0.7.5 release to production

https://gerrit.wikimedia.org/r/1165182