Page MenuHomePhabricator

Tabular JSON editing doesn't work on moderately sized pages: "Dataset is too large to edit as a table"
Closed, ResolvedPublic

Description

I tried clicking "Edit as table" on https://commons.wikimedia.org/w/index.php?title=Data:Wikipedia_statistics/data.tab&action=edit and got an error that says "Dataset is too large to edit as a table".

image.png (300×144 px, 4 KB)

That JSON page is less than 50 kB of data. My computer has 80 GB of RAM. I know browsers are inefficient, but surely not so inefficient that they would have more than 1,000,000 times the overhead.

Please increase or remove the limit :)

Event Timeline

Seems to be in the JsonConfig extension, and the check is:

if ( json.data.length * json.schema.fields.length > 5000 ) {

Looks like it was pretty arbitrarily chosen back in T251759.

Change #1154143 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/JsonConfig@master] JsonEditDialog: Change error on large datasets to a warning

https://gerrit.wikimedia.org/r/1154143

Change #1154143 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] JsonEditDialog: Change error on large datasets to a warning

https://gerrit.wikimedia.org/r/1154143