Page MenuHomePhabricator

Contributions: Links should be blue when on the history page, not using AMC, and using MinervaNeue skin
Open, Stalled, Needs TriagePublic

Description

Summary

Technical notes

Right now, the colors are shown like this (i.e. in gray):

image.png (263×469 px, 36 KB)

However, the links in the page should be blue, as shown in the following screen:

image.png (260×390 px, 31 KB)

Acceptance criteria

  • Links in the contributions list, including links to user pages and those from IPReveal (the "Show IP" button and links to IPs once the button is clicked) are blue when using MinervaNeue.

Event Timeline

Change #1154024 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/skins/MinervaNeue@master] contributions: Make links to user pages and widgets in history page blue

https://gerrit.wikimedia.org/r/1154024

hector.arroyo renamed this task from Conributions: Links should be blue when on the history page, not using AMC, and using MinervaNeue skin to Contributions: Links should be blue when on the history page, not using AMC, and using MinervaNeue skin.Jun 5 2025, 1:21 PM
hector.arroyo changed the task status from Open to In Progress.

@Jdlrobson I see you worked on https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1013600 a while ago. In that patch, the selector .history-user a was intentionally not included in the CSS rules removed by the patch, keeping the userlink as gray (--color-subtle). As of today, that color also applies to an additional "Show IP" action link and the link to the IP itself it adds to the row when clicked.

Recently we merged https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1152687, where we had a discussion about whether having the links to user pages as gray was an intentional decision or if they should be colored as blue. We think they should be blue, but maybe you know why the user links were left as gray in the first place?

hector.arroyo changed the task status from In Progress to Stalled.Jun 27 2025, 11:52 AM

The patch is currently downvoted, which blocks the resolution of this task: https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1154024

The root cause seems a misunderstanding of what we want to archieve vs the reasons that made the rows gray in the first place.

IMO, the changes in the patch as they stand now are needed in order to make the links that are already clickable to be shown as blue while keeping the current behavior that makes the page hide secondary links if accessed with a mobile resolution (i.e. hide "prev", "next", "talk" "contribs", "blocks" & "undo" links on mobile).

@hector.arroyo I see you left an explanatory message on the patch. I believe @Jdlrobson-WMF is on a sabbatical until mid-August. @ovasileva is there anyone else on your team who could take a look in the meantime?

As discussed in Slack, I'm moving this ticket out of the sprint so we can discuss later if the links should be blue or kept as gray instead.