Page MenuHomePhabricator

Remove obsolete Graphite/statsd tracking from GrowthExperiments
Closed, ResolvedPublic

Description

Now that Graphite is read-only for a while, we can now be sure that this is final. This means we can remove all the code that sents metrics there.

This means especially:

		$this->statsFactory->withComponent( 'GrowthExperiments' )
			->getCounter( 'question_poster_edits_total' )
			->setLabel( 'tag', $tagId )
			->setLabel( 'wiki', $wiki )
			->copyToStatsdAt( $wiki . '.GrowthExperiments.QuestionPoster.' . $tagId ) // <-- this line should be removed everywhere!
			->increment();
			mw.track(
				'timing.growthExperiments.specialHomepage.navigationDuration',
				navigationEntries[ 0 ].loadEventEnd
			);
			// ⬆️ the part above, starting with "timing" or "counter", needs to be removed ⬆️
			// ⬇️ the part below, starting with "stats.", that we keep ⬇️
			mw.track(
				'stats.mediawiki_GrowthExperiments_homepage_loadeventend_seconds',
				navigationEntries[ 0 ].loadEventEnd,
				{
					// eslint-disable-next-line camelcase
					navigation_type: navigationEntries[ 0 ].type,
					wiki: mw.config.get( 'wgDBname' )
				}
			);

Event Timeline

@Michael, quick dashboard-hunt question:

I can’t find any Grafana panel that plots

mediawiki_GrowthExperiments_suggested_edits_queue_total{wiki="*",platform="*",status="*"}

(or the legacy Graphite path <wiki>.growthExperiments.suggestedEdits.<platform>.queue.<status>).

• mediawiki_GrowthExperiments_suggested_edits_queue_total
is live in Prometheus (it shows the default “Metric autogenerated by statsd_exporter” help string).

Before I remove the copyToStatsdAt() call : https://gerrit.wikimedia.org/g/mediawiki/extensions/GrowthExperiments/+/777ff20f8d357595ba889f608a6baab22c9edf1d/includes/HomepageModules/SuggestedEdits.php, do you know if:

  1. This metric ever surfaced on a dashboard that got renamed/archived?
  2. If not, should we create a new “Suggested Edits queue throughput” panel , or is Product ok querying it ad-hoc?

Thanks!

Change #1155689 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Remove obsolete Graphite / StatsD tracking

https://gerrit.wikimedia.org/r/1155689

@Michael, quick dashboard-hunt question:

I can’t find any Grafana panel that plots

mediawiki_GrowthExperiments_suggested_edits_queue_total{wiki="*",platform="*",status="*"}

(or the legacy Graphite path <wiki>.growthExperiments.suggestedEdits.<platform>.queue.<status>).

• mediawiki_GrowthExperiments_suggested_edits_queue_total
is live in Prometheus (it shows the default “Metric autogenerated by statsd_exporter” help string).

Before I remove the copyToStatsdAt() call : https://gerrit.wikimedia.org/g/mediawiki/extensions/GrowthExperiments/+/777ff20f8d357595ba889f608a6baab22c9edf1d/includes/HomepageModules/SuggestedEdits.php, do you know if:

  1. This metric ever surfaced on a dashboard that got renamed/archived?
  2. If not, should we create a new “Suggested Edits queue throughput” panel , or is Product ok querying it ad-hoc?

Thanks!

Thank you for noticing this! This is one of the many small initiatives that were started and not finished. If I remember correctly, this came out of the queue running empty on enwiki on some point. We wanted to have a panel that shows the percentage of empty queues per wiki, but that was not possible with Graphite querying logic. It might be possible now that we have Prometheus available.

So let's keep these metrics, because T375600: Create Grafana panel with percentage of (mobile) homepage views with no available tasks should now effectively be unblocked, and there we will make use of this once we prioritize that task.

Change #1155689 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Remove obsolete Graphite/StatsD tracking

https://gerrit.wikimedia.org/r/1155689

Change #1162971 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Retain suggested edits metrics

https://gerrit.wikimedia.org/r/1162971

Change #1162971 abandoned by Cyndywikime:

[mediawiki/extensions/GrowthExperiments@master] Retain suggested edits metrics

Reason:

We want to keep the overall (statslib) tracking of this suggested_edits_queue_total counter, but copying it to statsd/Graphite is not needed anymore.

https://gerrit.wikimedia.org/r/1162971