Page MenuHomePhabricator
Create Task
Maniphest T396311

Archive the mediawiki/tools/phan/PerfCheckPlugin gerrit repository
Open, Needs TriagePublic
Actions

Description

https://gerrit.wikimedia.org/r/admin/repos/mediawiki/tools/phan/PerfCheckPlugin,general

This was an experimental phan plugin to suggest performance optimizations, see T227569. I wrote it as an experiment in 2019, but then basically set it aside. It hasn't received any contributions since then, I haven't looked into integrating it in our phan stack, and I don't necessarily think all of its suggestions are valuable, especially in newer PHP versions. So, we should probably just archive the gerrit repo.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Zuul: [mediawiki/tools/phan/PerfCheckPlugin] Mark as archivedintegration/configmaster+4 -6
Customize query in gerrit

Related Objects

Event Timeline

Daimona created this task.Jun 8 2025, 8:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2025, 8:11 PM
Daimona mentioned this in T227569: Find a way to run phan PerfCheck plugin as non-voting in CI.Jun 8 2025, 8:14 PM
Jdforrester-WMF moved this task from Untriaged to Archive tools & others on the Projects-Cleanup board.Jun 8 2025, 8:18 PM
Aklapper updated the task description. (Show Details)Jun 9 2025, 10:25 AM
Aklapper added a comment.Jun 9 2025, 10:27 AM

I set the State to Read Only and edited the Description to say [ARCHIVED] See T396311.
See https://gerrit.wikimedia.org/g/mediawiki/tools/phan/PerfCheckPlugin

I'm always clueless if we also want to empty the repo content. Or if these my two changes are sufficient.

Daimona added a comment.Jun 9 2025, 1:11 PM
In T396311#10894910, @Aklapper wrote:

I'm always clueless if we also want to empty the repo content. Or if these my two changes are sufficient.

I think it would be nice to empty the repo, so that its status is more visible, and it also doesn't show up in codesearches etc. Is there a template file with the archival notice for this?

gerritbot added a comment.Jun 9 2025, 2:11 PM

Change #1154825 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[integration/config@master] Zuul: [mediawiki/tools/phan/PerfCheckPlugin] Drop from CI

https://gerrit.wikimedia.org/r/1154825

gerritbot added a project: Patch-For-Review.Jun 9 2025, 2:11 PM
gerritbot added a comment.Jun 9 2025, 2:24 PM

Change #1154825 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/tools/phan/PerfCheckPlugin] Mark as archived

https://gerrit.wikimedia.org/r/1154825

Stashbot added a comment.Jun 9 2025, 2:25 PM

Mentioned in SAL (#wikimedia-releng) [2025-06-09T14:25:25Z] <James_F> Zuul: [mediawiki/tools/phan/PerfCheckPlugin] Mark as archived, for T396311

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2025, 2:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits