Page MenuHomePhabricator
Create Task
Maniphest T396516

TypeaheadSearch: fix space between footer icon and text
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

There's no space between the footer icon and the text next to it

image.png (1,326×300 px, 48 KB)

What should have happened instead?:

There should be at least some space. Note that this currently looks right when thumbnails are included and the solution to this bug shouldn't affect that.

Software version: Codex 2.0.0

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update Codex from v2.2.0 to v2.2.1Catropemediawiki/coremaster+175 -111
TypeaheadSearch: Fix spacing in footer without thumbnailsFormasit-chijohdesign/codexmain+2 -0
Customize query in gerrit

Event Timeline

AnneT created this task.Jun 10 2025, 5:50 PM
Restricted Application added a project: Design-System-Team. · View Herald TranscriptJun 10 2025, 5:50 PM
Restricted Application added a subscriber: • Aklapper. · View Herald Transcript

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

CCiufo-WMF subscribed.Jun 18 2025, 8:40 PM

Just noting this doesn't seem to be a problem for Typeahead in Vector 2022:

image.png (451×114 px, 17 KB)

AnneT added a comment.Jun 18 2025, 9:26 PM

@CCiufo-WMF yeah, it's only when you don't have thumbnails enabled (which will be true on wikidata)

Adityakumar0545 subscribed.Jun 21 2025, 10:33 AM
Formasit-chijoh subscribed.Jun 25 2025, 11:20 AM

@AnneT I've been able to replicate this. I will start working on a patch

gerritbot added a comment.Jun 26 2025, 7:31 AM

Change #1164117 had a related patch set uploaded (by Formasit-chijoh; author: Formasit-chijoh):

[design/codex@main] Fix spacing in TypeheadSearch footer without thumbnails

https://gerrit.wikimedia.org/r/1164117

gerritbot added a project: Patch-For-Review.Jun 26 2025, 7:31 AM
CCiufo-WMF assigned this task to Adityakumar0545.Jun 26 2025, 1:59 PM
CCiufo-WMF moved this task from Backlog to In Progress on the Codex board.
Formasit-chijoh added a comment.Jun 26 2025, 2:09 PM
In T396516#10949382, @gerritbot wrote:

Change #1164117 had a related patch set uploaded (by Formasit-chijoh; author: Formasit-chijoh):

[design/codex@main] Fix spacing in TypeheadSearch footer without thumbnails

https://gerrit.wikimedia.org/r/1164117

@CCiufo-WMF I have made a patch for this and it is ready for review, I could not assigned myself to the task so I indicated I was working on it

CCiufo-WMF reassigned this task from Adityakumar0545 to Formasit-chijoh.Jun 26 2025, 2:14 PM
CCiufo-WMF moved this task from In Progress to Code Review on the Codex board.

Oops, sorry about that @Formasit-chijoh ! Re-assigned to you. I'll see if someone is available to review.

Formasit-chijoh added a comment.EditedJun 26 2025, 2:16 PM

Thank you :)

AnneT moved this task from Code Review to Pending Release on the Codex board.Jun 26 2025, 3:03 PM
gerritbot added a comment.Jun 26 2025, 3:18 PM

Change #1164117 merged by jenkins-bot:

[design/codex@main] TypeaheadSearch: Fix spacing in footer without thumbnails

https://gerrit.wikimedia.org/r/1164117

Maintenance_bot removed a project: Patch-For-Review.Jun 26 2025, 3:31 PM
DTorsani-WMF triaged this task as High priority.Jul 10 2025, 10:40 AM
gerritbot added a comment.Jul 22 2025, 10:05 PM

Change #1171718 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v2.2.0 to v2.2.1

https://gerrit.wikimedia.org/r/1171718

gerritbot added a project: Patch-For-Review.Jul 22 2025, 10:05 PM
gerritbot added a comment.Jul 23 2025, 12:01 AM

Change #1171718 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v2.2.0 to v2.2.1

https://gerrit.wikimedia.org/r/1171718

Maintenance_bot removed a project: Patch-For-Review.Jul 23 2025, 12:31 AM
Catrope closed this task as Resolved.Jul 28 2025, 7:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits