Page MenuHomePhabricator

xLab: Update copy of activation confirmation dialog
Closed, ResolvedPublic1 Estimated Story Points

Description

Problem

Recent changes to the 'Traffic and variations' section (fka 'Sampling') in the experiment configuration form resulted in the introduction of new fields that cannot be modified after activation ('User identifier type'), and the enabling of fields that previously couldn't be edited after activation (e.g. 'User traffic per wiki'). As a consequence, the copy of the confirmation dialog that lists the fields that won't be editable after an experiment is activated is inaccurate and needs to be updated.

Solution

Once we are set on which fields in the 'Traffic and variations' section won't be editable after activation, we should update the copy of the activation confirmation dialog so it includes accurate information.

Known restricted fieldsPotentially restricted fields
InstrumentMachine-readable nameName (?), Sample rate per wiki, Start date (This is to prevent blocking the edition of non-restricted fields due to start date validation)
ExperimentMachine-readable name, User identifier type, VariationsName (?), User traffic per wiki, Start date (This is to prevent blocking the edition of non-restricted fields due to start date validation)
Acceptance criteria
  • The copy of the activation confirmation dialog accurately lists the experiment fields that won't be editable after activation

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
updated copy for the activation confirmation dialogrepos/data-engineering/test-kitchen!255sfaciT396578-update-copy-activationmain
Customize query in GitLab

Event Timeline

Sarai-WMF renamed this task from xLab: Correct copy of activation confirmation dialog to xLab: Updatege copy of activation confirmation dialog.Jun 13 2025, 3:19 PM
Sarai-WMF updated the task description. (Show Details)
Sarai-WMF renamed this task from xLab: Updatege copy of activation confirmation dialog to xLab: Update copy of activation confirmation dialog.Jun 13 2025, 5:52 PM

This task's parent Epic was resolved coinciding with the conclusion of hypothesis SDS2.4.13 at the end of FY24-25. This pending subtask can be considered foundational/essential work now, and until we may decide whether it should be housed under a particular KR.

Milimetric moved this task from Incoming to Backlog on the Test Kitchen board.
Milimetric set the point value for this task to 1.
Milimetric raised the priority of this task from Low to Medium.Sep 25 2025, 6:23 PM

According to how xLab is working right now, the blocked fields once an instrument/experiment is activated are the following:

  • For instruments: name, sample unit, sample rate per wiki and risk level
  • For experiments: name, user identifier type, user traffic per wiki, variation name and risk level

So the corresponding activation confirmation messages have been updated accordingly

Change #1193136 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] xLab: Deploying v1.0.6 release to staging

https://gerrit.wikimedia.org/r/1193136

Change #1193136 merged by jenkins-bot:

[operations/deployment-charts@master] xLab: Deploying v1.0.6 release to staging

https://gerrit.wikimedia.org/r/1193136

Change #1193878 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] xLab: Deploying v1.0.6 release to production

https://gerrit.wikimedia.org/r/1193878

Change #1193878 merged by jenkins-bot:

[operations/deployment-charts@master] xLab: Deploying v1.0.6 release to production

https://gerrit.wikimedia.org/r/1193878