PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Ammarpad
	Jun 11 2025, 11:13 AM

Description

Error

service.version: 1.45.0-wmf.4
trace.id: c4e60eee-2361-422f-aaa7-eb2f8e7934df
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated

Frame	Location	Call
from	/srv/mediawiki/php-1.45.0-wmf.4/extensions/AbuseFilter/includes/View/AbuseFilterViewEdit.php(1303)
#0	[internal function]	MediaWiki\Exception\MWExceptionHandler::handleError(int, string, string, int)
#1	/srv/mediawiki/php-1.45.0-wmf.4/extensions/AbuseFilter/includes/View/AbuseFilterViewEdit.php(1303)	trim(null)
#2	/srv/mediawiki/php-1.45.0-wmf.4/extensions/AbuseFilter/includes/View/AbuseFilterViewEdit.php(180)	MediaWiki\Extension\AbuseFilter\View\AbuseFilterViewEdit->loadRequest(int)
#3	/srv/mediawiki/php-1.45.0-wmf.4/extensions/AbuseFilter/includes/View/AbuseFilterViewEdit.php(145)	MediaWiki\Extension\AbuseFilter\View\AbuseFilterViewEdit->attemptSave(int, null)
#4	/srv/mediawiki/php-1.45.0-wmf.4/extensions/AbuseFilter/includes/Special/SpecialAbuseFilter.php(172)	MediaWiki\Extension\AbuseFilter\View\AbuseFilterViewEdit->show()
#5	/srv/mediawiki/php-1.45.0-wmf.4/includes/specialpage/SpecialPage.php(734)	MediaWiki\Extension\AbuseFilter\Special\SpecialAbuseFilter->execute(string)
#6	/srv/mediawiki/php-1.45.0-wmf.4/includes/specialpage/SpecialPageFactory.php(1738)	MediaWiki\SpecialPage\SpecialPage->run(string)
#7	/srv/mediawiki/php-1.45.0-wmf.4/includes/actions/ActionEntryPoint.php(499)	MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#8	/srv/mediawiki/php-1.45.0-wmf.4/includes/actions/ActionEntryPoint.php(143)	MediaWiki\Actions\ActionEntryPoint->performRequest()
#9	/srv/mediawiki/php-1.45.0-wmf.4/includes/MediaWikiEntryPoint.php(198)	MediaWiki\Actions\ActionEntryPoint->execute()
#10	/srv/mediawiki/php-1.45.0-wmf.4/index.php(58)	MediaWiki\MediaWikiEntryPoint->run()
#11	/srv/mediawiki/w/index.php(3)	require(string)
#12	{main}

Impact

Notes

Details

Request URL: https://ko.wikipedia.org/wiki/%ED%8A%B9%EC%88%98:%ED%8E%B8%EC%A7%91%ED%95%84%ED%84%B0/90

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Provide default for missing request values on Special:AbuseFilter/new	mediawiki/extensions/AbuseFilter	REL1_43	+3 -3
Provide default for missing request values on Special:AbuseFilter/new	mediawiki/extensions/AbuseFilter	REL1_44	+3 -3
Provide default for missing request values on Special:AbuseFilter/new	mediawiki/extensions/AbuseFilter	REL1_39	+3 -3
Provide default for missing request values on Special:AbuseFilter/new	mediawiki/extensions/AbuseFilter	master	+3 -3

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Subtype	Assigned	Task
			· · ·
Resolved		None	T379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
Resolved	PRODUCTION ERROR	Umherirrender	T396591 PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
			· · ·

Event Timeline

Ammarpad created this task.Jun 11 2025, 11:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2025, 11:13 AM

Reedy moved this task from Backlog to Bundled extensions/skins on the PHP 8.1 support board.Jun 11 2025, 12:12 PM

Reedy added a parent task: T379874: ☂ PHP 8.1 issues found during WMF rollout/ramp up.

Hmm, WebRequest::getVal is discouraged, yet AbuseFilter makes use of it. Is there any gotcha in changing these calls to WebRequest::getText?

According to the PHPDoc of WebRequest::getVal(),

It doesn't normalize line breaks and defaults to null instead of the empty string.

The second part clearly causes a bug here, but may mean a feature elsewhere (and it’s irrelevant when a custom default is provided, unless that default is null – which isn’t allowed by WebRequest::getText()). The first part is unlikely but not impossible to be significant (who wants to see CRLFs in inputs? well, maybe someone does).

Change #1171706 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] Provide default for missing request values on Special:AbuseFilter/new

https://gerrit.wikimedia.org/r/1171706

Umherirrender claimed this task.Jul 22 2025, 8:04 PM

gerritbot added a project: Patch-For-Review.Jul 22 2025, 8:04 PM

Change #1171706 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Provide default for missing request values on Special:AbuseFilter/new

https://gerrit.wikimedia.org/r/1171706

Maintenance_bot removed a project: Patch-For-Review.Jul 23 2025, 2:30 PM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.12; 2025-07-29).Jul 23 2025, 3:00 PM

Umherirrender closed this task as Resolved.Jul 23 2025, 5:31 PM

Change #1172076 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@REL1_44] Provide default for missing request values on Special:AbuseFilter/new

https://gerrit.wikimedia.org/r/1172076

Change #1172077 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@REL1_43] Provide default for missing request values on Special:AbuseFilter/new

https://gerrit.wikimedia.org/r/1172077

Change #1172078 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@REL1_39] Provide default for missing request values on Special:AbuseFilter/new

https://gerrit.wikimedia.org/r/1172078

Change #1172078 merged by jenkins-bot: