Page MenuHomePhabricator

Off-by-one error in number of languages in language button for translatable pages
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Use Vector-2022
  • Enable the Translate extension and translatable pages
  • In LocalSettings, add $wgPageTranslationLanguageList = 'sidebar-only';
  • Create a page on the wiki, add some <translate> tags
  • Mark the page for translation via the link on top, and don't set any priority languages

What happens?:

  • The language button at the top right (or left for RTL languages) shows "2 languages", even though the page hasn't yet been translated into any languages.
  • When you click the language button, there is only one language available

Screenshot_20250611_151133.png (418×976 px, 19 KB)

What should have happened instead?:

  • The button should have the correct number of languages (1 for a newly-marked page with no translations and no priority languages set)

Other information (browser name/version, screenshots, etc.): This is a regression caused by the change to Hooks.php in Ia73b8d85fb90edc604b38bc8e54ccc69cd1d3082.

Event Timeline

Change #1155667 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Translate@master] Display correct number of languages in language button

https://gerrit.wikimedia.org/r/1155667

abi_ triaged this task as High priority.
abi_ moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.

Change #1155667 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Display correct number of languages in language button

https://gerrit.wikimedia.org/r/1155667