Page MenuHomePhabricator
Create Task
Maniphest T396633

[MEX] Property label and link is included in the SSR version
Closed, ResolvedPublic
Actions

Description

In view/src/ItemView.php, the Item data only directly includes the Property Id, and not the human-readable label for the property.

Elsewhere (for example, view/src/StatementGroupListView.php), the property label is obtained using an instance of EntityIdFormatter.

Acceptance Criteria

the SSR version of the MEX statement:

  • uses the property's label in template rendering
  • links to the property correctly (replacing the non-functional string interpolation)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use property label in MEX SSRmediawiki/extensions/Wikibasemaster+20 -5
Use Pinia store to stash server-rendered HTMLmediawiki/extensions/Wikibasemaster+229 -18
Improve property label and link in mobile statement templatemediawiki/extensions/Wikibasemaster+39 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

AudreyPenven_WMDE created this task.Jun 11 2025, 4:18 PM
AudreyPenven_WMDE mentioned this in T396634: [MEX] Property label and link is included in the Vue-rendered Statement.Jun 11 2025, 4:30 PM
AudreyPenven_WMDE renamed this task from [MEX] Property label is included in the SSR version to [MEX] Property label and link is included in the SSR version.Jun 11 2025, 4:39 PM
AudreyPenven_WMDE updated the task description. (Show Details)
karapayneWMDE added a project: Wikidata-Omega.Jun 12 2025, 10:16 AM
gerritbot added a comment.Jun 13 2025, 2:42 PM

Change #1156848 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Improve property label and link in mobile statement template

https://gerrit.wikimedia.org/r/1156848

gerritbot added a project: Patch-For-Review.Jun 13 2025, 2:42 PM
gerritbot added a comment.Jun 16 2025, 5:43 PM

Change #1156848 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Improve property label and link in mobile statement template

https://gerrit.wikimedia.org/r/1156848

Maintenance_bot removed a project: Patch-For-Review.Jun 16 2025, 6:30 PM
Arian_Bozorg updated the task description. (Show Details)Jun 25 2025, 8:45 AM
Arian_Bozorg moved this task from Incoming to The Backlog on the Wikidata-Omega board.Jun 25 2025, 9:08 AM
Lucas_Werkmeister_WMDE claimed this task.Jul 11 2025, 2:04 PM
Lucas_Werkmeister_WMDE edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.
Lucas_Werkmeister_WMDE moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Jul 11 2025, 2:47 PM

Change #1168197 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Use property label in MEX SSR

https://gerrit.wikimedia.org/r/1168197

gerritbot added a project: Patch-For-Review.Jul 11 2025, 2:47 PM
gerritbot added a comment.Jul 14 2025, 9:44 AM

Change #1169048 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Use property label in MEX CSR

https://gerrit.wikimedia.org/r/1169048

gerritbot added a comment.Jul 15 2025, 12:05 PM

Change #1169643 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use Pinia store to stash server-rendered HTML

https://gerrit.wikimedia.org/r/1169643

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Jul 15 2025, 12:11 PM
Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
Lucas_Werkmeister_WMDE subscribed.

I think this is ready for review (though it could probably use another cleanup change to properly inject services in PHP).

AudreyPenven_WMDE claimed this task.Jul 15 2025, 3:38 PM
AudreyPenven_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Jul 16 2025, 8:05 AM

Change #1169643 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use Pinia store to stash server-rendered HTML

https://gerrit.wikimedia.org/r/1169643

gerritbot added a comment.Jul 17 2025, 1:51 PM

Change #1168197 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use property label in MEX SSR

https://gerrit.wikimedia.org/r/1168197

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.11; 2025-07-22).Jul 17 2025, 2:00 PM
AudreyPenven_WMDE removed AudreyPenven_WMDE as the assignee of this task.Jul 17 2025, 2:01 PM
AudreyPenven_WMDE moved this task from In Peer Review to Ready for Tech Verification on the Wikidata-Omega (The Board) board.
karapayneWMDE closed this task as Resolved.Jul 21 2025, 4:28 PM
karapayneWMDE claimed this task.
karapayneWMDE moved this task from Ready for Tech Verification to In Tech Verification on the Wikidata-Omega (The Board) board.
karapayneWMDE moved this task from In Tech Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.
karapayneWMDE edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega (The Board).
karapayneWMDE moved this task from Newly completed tasks to 2025 Q4 on the Wikidata-Omega (Completed Tasks) board.Jul 22 2025, 8:45 AM
karapayneWMDE moved this task from 2025 Q4 to 2025 Q3 on the Wikidata-Omega (Completed Tasks) board.Sep 4 2025, 12:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits