| Samwilson | |
| Jun 11 2025, 10:51 PM |
| F62776369: blk_vector22.png | |
| Jul 2 2025, 8:52 AM |
| F62776364: blk_timeless.png | |
| Jul 2 2025, 8:52 AM |
| F62602747: monobook.png | |
| Jun 27 2025, 2:28 PM |
| F62602662: timeless.png | |
| Jun 27 2025, 2:28 PM |
| F62602424: v22.png | |
| Jun 27 2025, 2:28 PM |
| F62443385: image.png | |
| Jun 24 2025, 1:54 PM |
| F62370772: image.png | |
| Jun 18 2025, 3:47 AM |
| F62349869: image.png | |
| Jun 17 2025, 6:38 AM |
The size and alignment of the favorite icon is wrong in Timeless:
(The underlines in the above screenshot have been enabled manually for demonstration; in actual use they only show on hover.)
(The following is from T390019#10917969.)
The "Mark as favorite" button is visually imbalanced with the "Watch" button. The latter uses a 16x16px icon, whereas the former is 20x20px.
Current appearance:
Proposed (bookmark is 16px):
Similar situation for Vector:
The hover colors in Vector-2022 are also different for the two buttons, #eaecf0 and #f8f9fa:
Change #1161704 had a related patch set uploaded (by Samwilson; author: Samwilson):
[mediawiki/extensions/TemplateData@master] Fix display of favorite button on template pages
Change #1163085 had a related patch set uploaded (by Samwilson; author: Samwilson):
[mediawiki/extensions/TemplateData@master] Simplify config of FavoriteButton on template pages
One of the above patches (the other is just a clean-up) adds styles for each of the three skins to make the template-page favorite icon display okay. We talked briefly about the idea of using Codex, but in the end it seems like there's too much difference between skins to make it worthwhile. I've not yet fixed the color for the Timeless icon, but will do if the above approach passes review.
Oh yep, I already added that to the above patch. Have updated the task description. Thanks!
(Fixed attachments to be public, due to Phab bug when editing post-creation via drag-and-drop.)
Change #1161704 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Fix display of favorite button on template pages
Change #1163085 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Simplify config of FavoriteButton on template pages
I am working on trying to view the icon on a number of different platforms and devices. Some very preliminary feedback:
Raised T398395.
- On Vector 2022 and Timeless, the favourite icon and watch star seem a bit out of alignment with the other items on that line
This is worse on some languages than others, including:
- On Vector 2010, should the icon be the same colour as the watch star? (This might be a separate ticket)
Raised T398404.
- On Timeless, the icon's outline is a bit thin compared to the watch star (again, perhaps a separate ticket)
Raised T398406.
- Monobook and Modern it is cut off (on Monobook everything on that row is cut off while logged in)
Raised T398206.