Page MenuHomePhabricator

notification-edit-talk-page request for clarification
Closed, ResolvedPublic

Description

A. A user on translatewiki.net has asked if GENDER is supported in message[1].

I have some some additional questions:
B. What's the link text of the diff link $3? A page title, so for example "User_talk:Siebrand"?
C. What does "formatted" mean in the description of $2?

[1] 'notification-edit-talk-page' => '$2 edited your talk page $3'

Documented as:
Format for displaying notifications of a user talk page being edited

  • $1 is the username of the person who edited, plain text.
  • $2 is the username of the person who edited, formatted.
  • $3 is a diff link, formatted.

Version: master
Severity: normal
URL: https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Notification-edit-talk-page/be-tarask

Details

Reference
bz37669

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:28 AM
bzimport added projects: Notifications, I18n.
bzimport set Reference to bz37669.
bzimport added a subscriber: Unknown Object (MLST).

Brion, Andrew? Are you both not involved in Echo anymore? Adding Terry on CC.

(In reply to comment #0)

A. A user on translatewiki.net has asked if GENDER is supported in message[1].
[1] 'notification-edit-talk-page' => '$2 edited your talk page $3'

Yes.

B. What's the link text of the diff link $3? A page title, so for example
"User_talk:Siebrand"?

The 'diff' message in brackets, like this:

'(' . wfMessage( 'diff' )->escaped() . ')'

(from formatters/EditFormatter.php)

C. What does "formatted" mean in the description of $2?

It's the HTML link to the user's page made with Linker::userLink. Take a look at function formatUser in formatters/NotificationFormatter.php.

Nemo_bis wants me to document this, reopening...

'(' . wfMessage( 'diff' )->escaped() . ')' is an i18n bug that should be reported and tracked separately.

(In reply to comment #4)

'(' . wfMessage( 'diff' )->escaped() . ')' is an i18n bug that should be
reported and tracked separately.

Could probably be solved by changing $3 to ($3) in the message...

Gerrit change 22283

Merged. You should probably open a separate bug for that hardcoded brackets problem.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptNov 15 2017, 8:09 PM