Rejecting all "add a link" suggestions sometimes leads to unintended edits
Closed, DuplicatePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Johannnes89
	Jun 12 2025, 3:27 PM

Description

Steps to replicate the issue:

Open Special:Homepage on a project where the "add a link" structured task is enabled.
Choose the "Add links between articles" task
Reject all machine suggestions
Save your changes

What happens?:

Usually nothing, because you haven't made any changes (e.g. this didn't cause any edit)
Sometimes rejecting all suggestions still leads to edits, e.g. 1, 2, 3, 4

What should have happened instead?:

Other information:

I'm assuming this happens when the link suggestion occurs in an article section which includes syntax VisualEditor cannot properly deal with? Rejecting all suggestions should lead to the edit being aborted.

Mentioned Here: T340532: Structured tasks should never make an edit when the user rejects the recommendation

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Thanks for reporting! I vaguely recall this used to happen before and that we fixed it somehow. Maybe we need to add better test coverage for that?

Thanks for reporting, and sorry to hear this is happening!

I believe this happens in certain edge cases due to some Parsoid quirks.
Here's a related task with more details: T340532: Structured tasks should never make an edit when the user rejects the recommendation

I do not see any substantial differences between this task and T340532, so I merged them. Feel free to reverse if that wasn't appropriate!

	F62303993: Screenshot 2025-06-12 at 17.24.44.png
	Jun 12 2025, 3:27 PM