Page MenuHomePhabricator

Adding tracking to "Learn more" link in Tone Check card/hint
Closed, ResolvedPublic

Description

This task involves the work of adding the instrumentation necessary to log the edit sessions within which people click/tap the Learn more link T390248 implements.

Story

As a member of the Editing Team , I'd value knowing when people who see a Tone Check while editing tap the Learn more link that is present within the Check card/hint so that I can learn things like: a) the extent to which people seek out additional context/instruction beyond what the current UX offers and b) how engaging with the Learn more link relates to the likelihood that someone will go on to publish a constructive new content edit.

Requirements

log feature: editCheck-tone, action: click-learn-more when someone clicks on the Learn more link in the Tone Check card/hint.

QA

Details

Related Changes in Gerrit:

Event Timeline

Change #1149663 had a related patch set uploaded (by DLynch; author: Divec):

[mediawiki/extensions/VisualEditor@master] WIP: Tone check

https://gerrit.wikimedia.org/r/1149663

The patch will now log feature: editCheck-tone, action: click-learn-more when someone clicks on the learn more link in the tone check.

The patch will now log feature: editCheck-tone, action: click-learn-more when someone clicks on the learn more link in the tone check.

Excellent and @DLynch – would it be accurate for me to think we'll be able to relate those clicks to the specific edit session they happened within

cc @MNeisler for awareness and review.

Yes, same as any other logging to VisualEditorFeatureUse.

Change #1149663 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Tone check

https://gerrit.wikimedia.org/r/1149663

Error:

TypeError: Invalid counter value for mediawiki_editcheck_preSaveChecks_total
    at eval (statsd.js:176:18)
    at Object.handler (mediawiki.base.js:416:5)
    at fire (jquery.js:3223:31)
    at Object.fireWith (jquery.js:3353:7)
    at Object.fire (jquery.js:3361:10)
    at mw.track (mediawiki.base.js:386:17)
    at eval (load.php?lang=en&modules=ext.visualEditor.editCheck&skin=vector-2022&version=1c867:12:703)
    at eval (oojs-ui-windows.js:756:33)
    at OO.ui.Process.execute (oojs-ui-windows.js:792:39)
    at ve.init.mw.ArticleTarget.showSaveDialog (ve.init.mw.ArticleTarget.js:1991:22)

Logs as expected:

{
    "wiki": "enwiki",
    ...
    "feature": "editCheck-tone",
    "action": "click-learn-more",
    "editor_interface": "visualeditor"
}

I've verified this event appears to be recorded correctly within visualeditorfeatureuse as well based on a few test events logged earlier in the week.

I've also added it to the VEFU dictionary