Page MenuHomePhabricator

Support "other assignee" field for tasks with "Task" type
Closed, ResolvedPublic

Description

See on T388099#10914701 - I wanted to list myself as "other assignee", but that isn't supported for the "Task" subtype so I had to change the subtype back to do it.

Event Timeline

Mentioned in SAL (#wikimedia-releng) [2025-07-22T19:48:54Z] <brennen> phab/phorge: adding "other assignee" visibility to more forms (T396905)

brennen added subscribers: egardner, brennen.

This came up in WMF Slack discussion with @egardner today, which prompted me to search and notice this task. For consistency, I made the field visible on:

There are probably other places it could be added for consistency. I'll poke around a bit.

I expect that this will increase its use and then lead to complaints about how it doesn't function like a "real" assignment, but it's already been added a bunch of places and there's clearly appetite for it.

A better solution to the underlying problem would probably be upstream work to support multiple assignees, but I'm sure that's not trivial.

brennen changed the task status from Open to Stalled.Jul 23 2025, 5:44 PM
brennen moved this task from Backlog to Doing/Involved on the User-brennen board.

Also changed:

We've got a much larger set of forms in use than I think I realized, and I'm kind of reluctant to mess with more workflows that I'm not super familiar with. Putting a pin in this one to chat about it with @Aklapper when he's back.

brennen moved this task from Doing/Involved to Done or Declined on the User-brennen board.

After discussion, calling this good where it's at for now. If anyone would like the field visible anywhere it's currently not, please let us know.

Thanks! FYI getting a list all Forms which expose a (custom) field:
SELECT CONCAT("https://phabricator.wikimedia.org/maniphest/task/edit/form/",id), engineKey, builtinKey, name FROM phabricator_search.search_editengineconfiguration WHERE properties LIKE "%field.name%" AND properties NOT LIKE "%field.name\":\"hidden%"; (replace field.name by whatever is in https://phabricator.wikimedia.org/config/edit/maniphest.custom-field-definitions/ )

If anyone would like the field visible anywhere it's currently not, please let us know.

@brennen In case you (and/or anyone else) feel like doing some more diving into Phab configuration... the 'Change Other Assignee' option doesn't seem to currently appear in the Add Action... dropdown for tasks with the 'Feature Request' subtype (e.g. this task), but does seem to appear in the dropdown for (at least some) other subtypes.

screenshot (feature subtype).png (546×710 px, 127 KB)
screenshot (task subtype).png (568×638 px, 127 KB)
Add Action... dropdown for the feature subtypeAdd Action... dropdown for the task subtype

I expected that editing https://phabricator.wikimedia.org/config/edit/maniphest.subtypes/ would have fixed this by setting "custom.train.backup": { "disabled": false}, for feature.
Having done that, I see no change in behavior.
The entire JSON settings for this are confusing, there are both "custom.train.backup" and "train.backup" in there.
Or is this maybe related to Edit Forms configurations?
Sigh.