Page MenuHomePhabricator

UserInfoCard: Display number of times a temporary account has had its IP revealed
Closed, ResolvedPublic0.5 Estimated Story Points

Description

Summary

If the logged-in user viewing the UserInfoCard has temporary account IP reveal rights, then the UserInfoCard should show how many times a given temporary account has had its IP revealed.

Technical notes

  • Add output to the CheckUserInfoCardService that includes the count of IP reveals for a given temporary account.

Acceptance criteria

  • The CheckUserInfoCardService and API endpoint have a count of temporary account IP reveals for users with the temporary account IP reveal permissions
  • The UserInfoCard displays this data point for users with temporary account IP reveal permissions
  • make the link conditional on the user having the checkuser-temporary-account-log right

Event Timeline

@KColeman-WMF @Niharika I filed this task based on T395212#10915463. What do you think?

I think it sounds fine. @MMoss_WMF any thoughts on this idea?

@Johannnes89 would you also want to have "Date of last IP reveal" or is the count of IP reveals enough to be a useful signal to you?

I think the date is less important than knowing if someone has already checked the temporary account or not, but if it’s not much effort to implement… (I might be the wrong person to judge this, as I have access to Special:Log/checkuser-temporary-account anyway). I‘m assuming patrollers and admins would be happy about the date, because recency of the last check might be another reason (not) to check a temporary account's IP address.

@KColeman-WMF @Niharika I filed this task based on T395212#10915463. What do you think?

I think it sounds fine. @MMoss_WMF any thoughts on this idea?

The idea looks good to me, no further thoughts right now.

We could add a line similar to this:

IP reveals: 1 (last checked 22 Feb 2025)

image.png (1,038×996 px, 192 KB)

Would the text link anywhere? There may be better ways to word this, but we also want to keep the text concise and not too long for translations.

We could add a line similar to this:

IP reveals: 1 (last checked 22 Feb 2025)

image.png (1,038×996 px, 192 KB)

Would the text link anywhere? There may be better ways to word this, but we also want to keep the text concise and not too long for translations.

It can link to Special:Log?type=checkuser-temporary-account&page=User:{username}

IP reveals sounds fine to me.

Would the text link anywhere?

It can link to Special:Log?type=checkuser-temporary-account&page=User:{username}

Admins & temporary account viewers cannot open the log, not sure if it's good UX to link something that only few people (CU, stewards, ombuds, staff) can access? If it's not too much work and the link can be provided just for those groups it would save us some clicks though...

Would the text link anywhere?

It can link to Special:Log?type=checkuser-temporary-account&page=User:{username}

Admins & temporary account viewers cannot open the log, not sure if it's good UX to link something that only few people (CU, stewards, ombuds, staff) can access? If it's not too much work and the link can be provided just for those groups it would save us some clicks though...

Yes, we can make the link conditional on the user having the checkuser-temporary-account-log right. As this feature is all about providing convenience to the end-user, it seems like a good idea to provide the link when it can be used.

Change #1164992 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] UserInfo: Display number of times a temporary account has had its IP revealed

https://gerrit.wikimedia.org/r/1164992

Pending to make the frontend changes to show the new value in the info card

kostajh set the point value for this task to 0.5.Jul 23 2025, 10:29 AM

I've rebased the previous patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1164992 and is now ready for review again. Tests are failing after the rebase, I've drafted the patch.

Tests are passing again and all the issues previously raised during the code review have been addressed, so this may go back to code review now.

I've rebased the patch and is ready for review again.

After the recent changes, tests from CheckUserUserInfoCardServiceTest are passing in my local environment but failing when they are run in Jenkins.

I've drafted the patch.

Change #1164992 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] UserInfoCard: Show how many times a temp account has had its IP revealed

https://gerrit.wikimedia.org/r/1164992

Dreamy_Jazz subscribed.

Given the current size of the QA queue, I think this can skip QA.