Page MenuHomePhabricator

EditCheck: Remove appearance panel in @breakpoint-desktop-wide
Open, Needs TriagePublic

Description

Background

In breakpoint-desktop-wide (1680px screens and larger), the "Appearance" panel is displayed when no checks are visible, then collapses once the checks appear. This creates confusion.

Grabaciondepantalla2025-06-12alas18.40.25-ezgif.com-video-to-gif-converter.gif (350×800 px, 2 MB)

We need to ensure consistency with the breakpoint-desktop by not displaying the "Appearance" panel expanded while editing. Instead, it should be collapsed under the Appearance icon within the header.

Acceptance criteria (or Done)

  • The "Appearance" panel is collapsed in both breakpoint-desktop-wide and breakpoint-desktop

Event Timeline

Discussion offline with @JScherer-WMF in Nov 2024 landed on: we would be hiding Vector 2022's Tools and Appearance menus when entering an edit session with the visual editor with edit check enabled and bring them back once the users return to read mode.

Change #1218816 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] EditCheck: Make appearance panel behavior consistent across screen sizes

https://gerrit.wikimedia.org/r/1218816

We discussed this in our engineering meeting and the consensus was that this short-term fix may not be the right move right now. Related to a point that Quiddity brought up in Slack about how the tools/appearance menu being completely inaccessible during editing may not be received well by experienced editors. There's a patch ready if we want to move forward, but I figured I'd move this to blocked to discuss.