Page MenuHomePhabricator

EditCheck: Improve pagination in the Pre-save moment
Closed, ResolvedPublic

Description

Background

At the moment, there are some confusing behaviors when using the pagination in the Pre-save moment:

  1. The Edit Check cards are not animated, and the pagination buttons don't navigate to the corresponding highlighted text, making it difficult to connect each Edit Check with its related text.
  2. The panel with the Edit Checks and pagination remain fixed while the article can be scrolled. This creates confusion, as it's difficult to track where the visible check originates, and there is no easy way to jump back to the highlighted text, especially if it's far from the current scroll position.
  3. Pagination buttons use iconPrevious and iconNext (horizontal navigation) while the highlighted text in the page are scrolled vertically. This is confusing.

Grabaciondepantalla2025-06-17alas12.56.13-ezgif.com-video-to-gif-converter.gif (800×386 px, 2 MB)

Design proposal

Grabaciondepantalla2025-06-18alas16.49.12-ezgif.com-video-to-gif-converter.gif (600×333 px, 1 MB)

  • As you navigate between Checks using the pagination, the relevant text and its highlight move along with you
  • Pagination buttons use the iconCollapse and iconCollapse to align with the vertical scroll
  • Cards are also animated vertically to follow the same vertical behavior as scroll and buttons. This will be completed as part of T396575: Edit Check: Improve Animations.

Open questions

Add here the questions to be answered in order to design and implement the component

Acceptance criteria (or Done)

Design

  • Create proposal (and prototype) for the solutions described above

Implementation

  • Implement the changes proposed in the Pre-save moment of Edit Check

Future work

Event Timeline

bmartinezcalvo moved this task from Incoming to Done on the Design board.

Change #1164445 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] EditCheck: Use up/down arrows for navigating checks

https://gerrit.wikimedia.org/r/1164445

Change #1164445 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck: Use up/down arrows for navigating checks

https://gerrit.wikimedia.org/r/1164445

@Esanders I'm reviwing the Up/Down arrows in the last patch.

I just detected a couple of additional improvements to align the pagination with design:

  • The padding between Up/Down buttons should be 0px
  • The text/numbers in the pagination should use color-subtle

Since this task is to improve the pagination, could we include these changes as part of this task? cc: @ppelberg

Change #1165044 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: adjust display of navigation buttons

https://gerrit.wikimedia.org/r/1165044

Change #1165044 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: adjust display of navigation buttons

https://gerrit.wikimedia.org/r/1165044

Esanders added a project: Editing QA.

If the cards cannot be animated now, this could be completed as part of T396575: Edit Check: Improve Animations.

Yes, let's do that.

EAkinloose claimed this task.
EAkinloose edited projects, added: Verified; removed: Editing QA.