When the Edit Check appears in Mid-wdit on touchable screens, it’s difficult to recognize that there is something to fix. We could fix it by displaying the bottom sheet by default when the Edit Check appears.

We don't do this because mid-edit checks appear while you're typing, and so we cannot show a check without dismissing your keyboard and interrupting your typing. This is incredibly annoying when it happens unexpectedly, so we decided to show checks subtly, and then you'll be shown them all pre-save if you don't address them.

Change #1161523 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] EditCheck: Fix font size resets

https://gerrit.wikimedia.org/r/1161523

Change #1161523 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck: Fix font size resets

https://gerrit.wikimedia.org/r/1161523

Change #1163805 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] EditCheck mobile: Compute bounding rect for multi-selection checks

https://gerrit.wikimedia.org/r/1163805

Change #1163805 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck mobile: Compute bounding rect for multi-selection checks

https://gerrit.wikimedia.org/r/1163805

The blocked scroll part remains to be addressed, and we should do that.

I'm having trouble with reproducing the blocked scroll bug.

There are issues with the scroll when the bottom sheet is displayed, and it’s not possible to scroll until the end.

I've loaded this up on iOS safari, Android Chrome and in responsive mode in Firefox and Chrome, and I've tried it on my local wiki with latest ve, and on an enwiki page.

I chose a section, opened mobile editor, clicked on a "citation needed" suggestion, and scrolled down to the bottom. The bottom panel did not obscure the text. Example here from https://en.wikipedia.org/wiki/Coffeehouse?ecenable=2#/editor/2

Am I looking at the wrong panel?

El T397170#11517958, @zoe escribió:

I'm having trouble with reproducing the blocked scroll bug.

There are issues with the scroll when the bottom sheet is displayed, and it’s not possible to scroll until the end.

@zoe I've reproduced this on my Android and iOS and I cannot find any issue. Since this task was created some time ago, maybe this was a past issue that was solved in some moment. So let's ignore this for now.

In that case, I think we have done everything that remains on the task, so I will pass it over to QA.

For item 2:

When the Edit Check appears in Mid-edit on touchable screens, it’s difficult to recognize that there is something to fix. We could fix it by displaying the bottom sheet by default when the Edit Check appears.

For this case, it appears for pastecheck but not tone check.

Unrelated to ticket description, I see that we have extra spacing when EditCheck is enabled.

No ecenable passed

ecenable=2

No checks yet

Check. At this point, space goes back to normal

That's deliberate. When checks are enabled, the content is displayed slightly narrower so that there's space for the gutter to appear without causing the content to reflow.