Page MenuHomePhabricator

Reference Check: Disable the card when the "Add a citation" popover is displayed
Closed, DeclinedPublic

Description

Background

When adding a citation on desktop in the Pre-save moment of Paste Check, the “Add a citation” popup appears, and the buttons in the Edit Check are disabled. If the check card is non-interactive at all, having just the buttons disabled could lead to confusion for the user.

Captura de pantalla 2025-07-22 a las 11.43.19.png (1×2 px, 667 KB)

Proposed solution

Disable the check card while the “Add a citation” popup is displayed. The disabled state for the card is specified in T394713: EditCheck: Improve interactions

image.png (1×2 px, 845 KB)

Acceptance criteria (or Done)

Design

  • Explore solutions for the issues commented above

Implementation

  • Disable the entire card when the "Add a citation" popup is displayed

Event Timeline

Assigning this task over to Bárbara to evaluate the extent to which the issues this ticket describes are still happening in production.

Assigning this task over to Bárbara to evaluate the extent to which the issues this ticket describes are still happening in production.

Updated task description with the current issues to solve.

bmartinezcalvo renamed this task from Paste Check: Improve experience in the Pre-save moment to Paste Check: Disable the card when the "Add a citation" popover is displayed.Jul 22 2025, 9:47 AM

Moving relevant discussion over from T394713:

Disabled feels like overkill -- it's too low-contrast to be easily readable to my eyes, and it's specified to be used in places when someone might still want to refer to the contents of the card. E.g. in add-reference, the card still contains the explanation for why you should add a citation.

Disabled elements are not required to meet AA contrast standards, and the current contrast follows the same approach used across other disabled elements. If we introduce a collapsed disabled state in the future, it would follow this same color approach. For consistency, I recommend using the existing color tokens applied to other disabled components.

I suppose I could rephrase my position to "that shouldn't be disabled", if we have to use those colors.

To elaborate: I now don't think we should show the card as disabled, if that treatment is required. The actions within it are disabled, but the card is still the active task you're engaging with, which consists of the card and its instructions plus the citoid popup. (See also: the Tone check revise flow, where we're not going to make the tone directions illegible while you're revising.)

DLynch renamed this task from Paste Check: Disable the card when the "Add a citation" popover is displayed to Reference Check: Disable the card when the "Add a citation" popover is displayed.Jul 29 2025, 3:55 PM

@DLynch thank you for your feedback. So, after reviewing this one more time, your proposal makes sense. We could disable the actions (either the ones within the card or the important ones like "Publish) when they are affected by other actions in the page, like this "Add a citation" popover. So we can leave the card as it is: enabled with just the buttons disabled.

So declining this task.