Page MenuHomePhabricator

Button says "cancel" instead of "OK"
Closed, DeclinedPublic

Description

Author: rschnautz

Description:
When adding a user as an ambassador for a course, the success message displays with a button that says "Cancel". It should say "OK" (or something along that line), since the change has already committed and pressing the button wouldn't reverse it.


Version: unspecified
Severity: minor

Details

Reference
bz37718

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:22 AM
bzimport set Reference to bz37718.

Here the list of the messages containing the "Cancel" string:

  • ep-pager-cancel-button-org
  • ep-pager-cancel-button-course
  • ep-articletable-addreviwer-cancel
  • ep-articletable-remreviwer-cancel
  • ep-articletable-remstudent-cancel
  • ep-articletable-remarticle-cancel
  • coursepage-delete-cancel-button
  • orgpage-delete-cancel-button
  • orgpage-eprestore-cancel-button
  • coursepage-eprestore-cancel-button
  • orgpage-epundo-cancel-button
  • coursepage-epundo-cancel-button
  • coursepage-epundelete-cancel-button
  • orgpage-epundelete-cancel-button
  • ep-disenroll-cancel
  • ep-instructor-cancel-button
  • ep-instructor-add-cancel-button
  • ep-online-cancel-button
  • ep-online-add-cancel-button
  • ep-campus-cancel-button
  • ep-campus-add-cancel-button

So from a localisation point of view, it's okay.


The problem then becomes one of those:

  • a cancel button is used instead an OK button
  • the cancel operation don't remove the ambassador

I can't reproduce this. Initially the dialogue has an "Add ambassador" button and a "Cancel" one. After submitting, you get a success message and the buttons get replaced by a "Close" one.

I'm going to assume this has already been fixed. If I'm wrong, please reopen :)