Page MenuHomePhabricator
Create Task
Maniphest T397217

Implement a group by toggle for the RecentChanges/Watchlist/RelatedChanges special pages
Closed, ResolvedPublic
Actions

Description

To implement the group by toggle experiment we need to implement an experiment that captures the instrumentation spec we arrived at here.

Acceptance Criteria:

  • add the group by toggle
  • ensure the toggle only shows up when "toggled" parameter set to true

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Implement a group by toggle for the RecentChanges/Watchlist/RelatedChanges special pagesmediawiki/coremaster+83 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Kgraessle created this task.Jun 17 2025, 3:10 PM
Kgraessle triaged this task as High priority.
Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
Kgraessle set the point value for this task to 5.
Kgraessle removed the point value 5 for this task.Jun 17 2025, 3:12 PM
gerritbot added a comment.Jun 20 2025, 3:42 PM

Change #1162025 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/core@master] Implement a group by toggle for the RecentChanges/Watchlist/RelatedChanges special pages

https://gerrit.wikimedia.org/r/1162025

gerritbot added a project: Patch-For-Review.Jun 20 2025, 3:42 PM
Kgraessle updated the task description. (Show Details)Jun 20 2025, 3:55 PM
Kgraessle updated the task description. (Show Details)
PatchDemoBot added a comment.Jun 20 2025, 4:14 PM

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/b14b407e88/w/

Kgraessle added a subscriber: OTichonova.Jun 20 2025, 4:20 PM

Here are the Patchdemos for testing.

URL with query param enabled: https://patchdemo.wmcloud.org/wikis/b14b407e88/wiki/Special:RecentChanges?hidebots=1&limit=50&days=7&enhanced=1&urlversion=2&toggle=true

URL with query param disabled: https://patchdemo.wmcloud.org/wikis/b14b407e88/wiki/Special:RecentChanges?hidebots=1&limit=50&days=7&enhanced=1&urlversion=2

@OTichonova if you could review the stacking/design on the toggle whenever you get a chance! Thanks!

Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Jun 20 2025, 4:20 PM
OTichonova added a comment.Jun 20 2025, 7:06 PM

Hi @Kgraessle, thanks!
2 small things:

  1. When decreasing the size of the screen, the group by page toggle and the time filter stay grouped together and align left. Can they stack on top of each other and align right?
CurrentDesign
Screenshot 2025-06-20 at 15.49.58 1.png (481×1 px, 153 KB)
Group 5482.png (685×499 px, 121 KB)

14 pxl - 0.875 em; 26 pxl - 1.625 em

  1. The space between toggle and the filter is a tiny bit smaller than it should be (1pxl). Can it be increased to 12 pxl/0.75 em?
PatchDemoBot added a comment.Jun 20 2025, 8:20 PM

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/b14b407e88/w/

PatchDemoBot added a comment.Jun 20 2025, 8:40 PM

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/a74a380067/w/

PatchDemoBot added a comment.Jun 20 2025, 8:48 PM

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/a74a380067/w/

PatchDemoBot added a comment.Jun 20 2025, 9:11 PM

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/94b451613c/w/

PatchDemoBot added a comment.Jun 20 2025, 10:09 PM

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/94b451613c/w/

Kgraessle renamed this task from Implement a group by toggle for the treatment group to Implement a group by toggle for the RecentChanges/Watchlist/RelatedChanges special pages.Jun 20 2025, 10:33 PM
PatchDemoBot added a comment.Jun 20 2025, 10:35 PM

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/0b218a74ef/w/

PatchDemoBot added a comment.Jun 23 2025, 6:26 PM

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/0b218a74ef/w/

Kgraessle mentioned this in T397728: Add experiment code to group by toggle .Jun 24 2025, 2:58 PM
PatchDemoBot added a comment.Jun 24 2025, 7:39 PM

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/90d2a735d0/w/

Kgraessle added a comment.Jun 24 2025, 7:47 PM

@OTichonova

This should be ready to take a look at again. I was able to get the stacking working but wanted your input on the spacing.

OTichonova added a comment.Jun 24 2025, 8:03 PM

Hi @Kgraessle, looks good to me, thanks!

Scardenasmolinar moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Jun 24 2025, 8:17 PM
Kgraessle moved this task from Reviewed (waiting for changes) to In Progress on the Moderator-Tools-Team (Kanban) board.Jun 24 2025, 8:19 PM
PatchDemoBot added a comment.Jun 24 2025, 9:01 PM

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/90d2a735d0/w/

PatchDemoBot added a comment.Jun 24 2025, 9:24 PM

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/99f03bb62f/w/

Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Jun 24 2025, 10:32 PM
gerritbot added a comment.Jun 25 2025, 6:38 PM

Change #1162025 merged by jenkins-bot:

[mediawiki/core@master] Implement a group by toggle for the RecentChanges/Watchlist/RelatedChanges special pages

https://gerrit.wikimedia.org/r/1162025

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.8; 2025-07-01).Jun 25 2025, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 25 2025, 7:31 PM
Kgraessle moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Jun 25 2025, 9:09 PM
PatchDemoBot added a comment.Jul 1 2025, 12:56 PM

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/99f03bb62f/w/

Scardenasmolinar closed this task as Resolved.Jul 2 2025, 5:15 PM
Scardenasmolinar moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.
Scardenasmolinar subscribed.

The toggle is showing and working correctly when we pass the URL parameter

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits