Page MenuHomePhabricator

Preserve existing watchlist expiry on page edit
Closed, ResolvedPublic

Description

We have one bug report after rolling out T265716: Allow users to set their default watchlist item expiry time

I’ve set the default duration for manual watchlisting to indefinite, and the default duration for edited page watchlisting to one month. When editing a page that was already watchlisted indefinitely, the duration was shortened to one month. The behavior I want is that longer duration is prioritized, not later action’s. (I’ve make the same post on mw:Help talk:Watchlist expiry)

It occurs by DiscussionTools or mobile edit.

I think the correct solution is probably to set the dropdown value to the current expiry when the page is already on your watchlist.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1163068 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Leave watchlist expiry unchanged when param is omitted in API calls

https://gerrit.wikimedia.org/r/1163068

I can reproduce this problem with VisualEditor, with DiscussionTools, and with plain API calls using Special:ApiSandbox; and the patch fixes all of them.

I didn't test APIs other than action=edit much, but they should all behave in the same way.

Change #1163068 merged by jenkins-bot:

[mediawiki/core@master] Leave watchlist expiry unchanged when param is omitted in API calls

https://gerrit.wikimedia.org/r/1163068

Scardenasmolinar moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.

Changes work on testwiki