Page MenuHomePhabricator
Create Task
Maniphest T397245

Pass title to tone check API
Closed, ResolvedPublic
Actions

Description

when the model was trained, page title was used as an input to the model, in addition to the language code and the edit text. right now we're not passing in page title which could potentially result in a difference between the model's expected behavior vs. actual behavior. would it be possible for y'all to fetch and pass page title as an additional input from VE?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Pass page_title to tone check APImediawiki/extensions/VisualEditormaster+12 -2
Customize query in gerrit

Event Timeline

Esanders created this task.Jun 17 2025, 5:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2025, 5:57 PM
ppelberg added a subscriber: achou.Jun 18 2025, 7:18 PM
Esanders updated the task description. (Show Details)Jun 23 2025, 5:17 PM
gerritbot added a comment.Jun 23 2025, 5:22 PM

Change #1162981 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Pass page_title to tone check API

https://gerrit.wikimedia.org/r/1162981

gerritbot added a project: Patch-For-Review.Jun 23 2025, 5:22 PM
ppelberg moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.Jul 10 2025, 9:54 PM
PatchDemoBot added a comment.Jul 14 2025, 4:46 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/7e2751a4d2/w/

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jul 14 2025, 5:17 PM
DLynch added a project: Editing QA.
ppelberg moved this task from Inbox to High Priority on the Editing QA board.Jul 14 2025, 5:18 PM
gerritbot added a comment.Jul 14 2025, 9:42 PM

Change #1162981 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Pass page_title to tone check API

https://gerrit.wikimedia.org/r/1162981

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.10; 2025-07-15).Jul 14 2025, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 14 2025, 10:31 PM
EAkinloose closed this task as Resolved.Jul 25 2025, 8:01 PM
EAkinloose claimed this task.
EAkinloose subscribed.

image.png (444×2 px, 125 KB)

PatchDemoBot added a comment.Sep 5 2025, 10:41 AM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/7e2751a4d2/w/

VPuffetMichel added a project: Essential-Work.Dec 8 2025, 10:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits