Page MenuHomePhabricator
Create Task
Maniphest T397262

PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated
FrameLocationCall
#1/srv/mediawiki/php-1.45.0-wmf.6/extensions/CentralAuth/includes/User/CentralAuthUser.php(2556)preg_match(string, null)
#2/srv/mediawiki/php-1.45.0-wmf.6/extensions/CentralAuth/includes/User/CentralAuthUser.php(763)MediaWiki\Extension\CentralAuth\User\CentralAuthUser->getPasswordFromString(null, string)
#3/srv/mediawiki/php-1.45.0-wmf.6/extensions/CentralAuth/includes/User/CentralAuthUser.php(3473)MediaWiki\Extension\CentralAuth\User\CentralAuthUser->getPasswordObject()
#4/srv/mediawiki/php-1.45.0-wmf.6/extensions/CentralAuth/includes/CentralAuthPrimaryAuthenticationProvider.php(215)MediaWiki\Extension\CentralAuth\User\CentralAuthUser->hasScrambledPassword()
#5/srv/mediawiki/php-1.45.0-wmf.6/includes/auth/AuthManager.php(521)MediaWiki\Extension\CentralAuth\CentralAuthPrimaryAuthenticationProvider->beginPrimaryAuthentication(array)
#6/srv/mediawiki/php-1.45.0-wmf.6/includes/auth/AuthManager.php(431)MediaWiki\Auth\AuthManager->continueAuthentication(array)
#7/srv/mediawiki/php-1.45.0-wmf.6/includes/specialpage/AuthManagerSpecialPage.php(408)MediaWiki\Auth\AuthManager->beginAuthentication(array, string)
#8/srv/mediawiki/php-1.45.0-wmf.6/includes/specialpage/AuthManagerSpecialPage.php(542)MediaWiki\SpecialPage\AuthManagerSpecialPage->performAuthenticationStep(string, array)
#9/srv/mediawiki/php-1.45.0-wmf.6/includes/htmlform/HTMLForm.php(825)MediaWiki\SpecialPage\AuthManagerSpecialPage->handleFormSubmit(array, MediaWiki\HTMLForm\CodexHTMLForm)
#10/srv/mediawiki/php-1.45.0-wmf.6/includes/specialpage/AuthManagerSpecialPage.php(473)MediaWiki\HTMLForm\HTMLForm->trySubmit()
#11/srv/mediawiki/php-1.45.0-wmf.6/includes/specialpage/LoginSignupSpecialPage.php(407)MediaWiki\SpecialPage\AuthManagerSpecialPage->trySubmit()
#12/srv/mediawiki/php-1.45.0-wmf.6/includes/specialpage/SpecialPage.php(732)MediaWiki\SpecialPage\LoginSignupSpecialPage->execute(null)
#13/srv/mediawiki/php-1.45.0-wmf.6/includes/specialpage/SpecialPageFactory.php(1722)MediaWiki\SpecialPage\SpecialPage->run(null)
#14/srv/mediawiki/php-1.45.0-wmf.6/includes/actions/ActionEntryPoint.php(499)MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#15/srv/mediawiki/php-1.45.0-wmf.6/includes/actions/ActionEntryPoint.php(143)MediaWiki\Actions\ActionEntryPoint->performRequest()
#16/srv/mediawiki/php-1.45.0-wmf.6/includes/MediaWikiEntryPoint.php(198)MediaWiki\Actions\ActionEntryPoint->execute()
#17/srv/mediawiki/php-1.45.0-wmf.6/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#18/srv/mediawiki/w/index.php(3)require(string)
Impact
Notes

Details

Request URL
https://auth.wikimedia.org/*/w/index.php?centralauthLoginToken=*&returnto=*&title=*&useformat=*&usesul3=*
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix password handling for non-existent usersmediawiki/extensions/CentralAuthwmf/1.45.0-wmf.6+15 -5
Fix password handling for non-existent usersmediawiki/extensions/CentralAuthmaster+15 -5
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jun 17 2025, 10:58 PM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptJun 17 2025, 10:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper added a project: PHP 8.1 support.Jun 17 2025, 11:21 PM
Reedy added subscribers: Tgr, Reedy.Jun 18 2025, 10:52 AM

Looks like this is related to T395372: Handle scrambled password type in CentralAuth/rECAU0421795ed937: Add support for password scrambling / unscrambling work...

Tgr added a comment.Jun 18 2025, 1:28 PM

CentralAuthUser::getPassword() is documented as always returning a string, but actually when the CentralAuthUser instance represents a user that does not exist centrally, it seems like it'll return null. The error is not directly related to password scrambling but maybe the relevant code path was unreachable before...

Tgr claimed this task.Jun 18 2025, 2:19 PM
Tgr moved this task from Inbox, needs triage to In progress (DO NOT USE) on the MediaWiki-Platform-Team board.Jun 18 2025, 5:12 PM
gerritbot added a comment.Jun 18 2025, 7:55 PM

Change #1161032 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/CentralAuth@master] Fix password handling for non-existent users

https://gerrit.wikimedia.org/r/1161032

gerritbot added a project: Patch-For-Review.Jun 18 2025, 7:55 PM
Aklapper mentioned this in T392176: 1.45.0-wmf.6 deployment blockers.Jun 19 2025, 5:14 PM
gerritbot added a comment.Jun 19 2025, 5:42 PM

Change #1161032 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Fix password handling for non-existent users

https://gerrit.wikimedia.org/r/1161032

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.7; 2025-06-24).Jun 19 2025, 6:00 PM
matmarex closed this task as Resolved.Jun 19 2025, 6:02 PM
matmarex subscribed.
Maintenance_bot removed a project: Patch-For-Review.Jun 19 2025, 6:30 PM
gerritbot added a comment.Jun 20 2025, 1:32 PM

Change #1161950 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/CentralAuth@wmf/1.45.0-wmf.6] Fix password handling for non-existent users

https://gerrit.wikimedia.org/r/1161950

gerritbot added a project: Patch-For-Review.Jun 20 2025, 1:32 PM
gerritbot added a comment.Jun 23 2025, 8:14 PM

Change #1161950 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.45.0-wmf.6] Fix password handling for non-existent users

https://gerrit.wikimedia.org/r/1161950

Stashbot mentioned this in T395372: Handle scrambled password type in CentralAuth.Jun 23 2025, 8:14 PM
Stashbot mentioned this in T364705: Provide AbuseFilter condition for revertrisk threshold.

Mentioned in SAL (#wikimedia-operations) [2025-06-23T20:14:27Z] <kharlan@deploy1003> Started scap sync-world: Backport for [[gerrit:1162998|Map pre-save RR scores to predefined values (T364705)]], [[gerrit:1161950|Fix password handling for non-existent users (T395372 T397262)]]

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2025, 8:30 PM
Stashbot added a comment.Jun 23 2025, 8:38 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-23T20:38:46Z] <kharlan@deploy1003> kharlan, tgr: Backport for [[gerrit:1162998|Map pre-save RR scores to predefined values (T364705)]], [[gerrit:1161950|Fix password handling for non-existent users (T395372 T397262)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jun 23 2025, 8:59 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-23T20:58:57Z] <kharlan@deploy1003> Finished scap sync-world: Backport for [[gerrit:1162998|Map pre-save RR scores to predefined values (T364705)]], [[gerrit:1161950|Fix password handling for non-existent users (T395372 T397262)]] (duration: 44m 29s)

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.6; 2025-06-17); removed MW-1.45-notes (1.45.0-wmf.7; 2025-06-24).Jun 24 2025, 4:01 PM
Tgr added a comment.Jun 24 2025, 8:15 PM

Seems to have worked:

Screenshot Capture - 2025-06-24 - 22-15-39.png (560×1 px, 57 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits