Page MenuHomePhabricator
Create Task
Maniphest T397273

Update storage layer to handle the new country code field (add, update, read)
Closed, ResolvedPublic
Actions

Description

Acceptance criteria

  • Update the storage layer (AddressStore, EventStore) to handle the new country code field. (add, update, read)
  • This should work for all possible values of the migration flag

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
AddressStore: implement NEW stages for the country migrationmediawiki/extensions/CampaignEventsmaster+109 -53
Start reading country schema migration flag in AddressStoremediawiki/extensions/CampaignEventsmaster+376 -176
Minor adjustments for AddressStoreTest in preparation of migrationmediawiki/extensions/CampaignEventsmaster+65 -39
Have AddressStore::acquireAddressId() take Addressmediawiki/extensions/CampaignEventsmaster+51 -37
Introduce a value object to represent addressesmediawiki/extensions/CampaignEventsmaster+97 -46
Segregate address-specific code inside AddressStore and add testsmediawiki/extensions/CampaignEventsmaster+351 -175
Customize query in gerrit

Related Objects
Search...

Event Timeline

cmelo created this task.Jun 18 2025, 3:14 AM
cmelo mentioned this in T395621: Investigation: Update country field in event registration configuration to be a structured list.Jun 18 2025, 3:41 AM
Daimona removed a project: Epic.Jun 19 2025, 12:21 PM
Daimona added a comment.Jun 19 2025, 4:57 PM

Given the type of schema change involved, this will need to go through the full data migration process.

Daimona added a subtask: T397269: Create a new column to store the country code.Jun 19 2025, 5:01 PM
Daimona edited parent tasks, added: T397476: Country of event data migration (free text -> code; optional -> required; remove country from address); removed: T393967: [EPIC] Country of event.Jun 19 2025, 6:24 PM
Daimona removed a subtask: T397269: Create a new column to store the country code.
Daimona updated the task description. (Show Details)Jun 23 2025, 3:30 PM
Daimona updated the task description. (Show Details)
Daimona mentioned this in T397476: Country of event data migration (free text -> code; optional -> required; remove country from address).Jun 23 2025, 3:34 PM
Daimona moved this task from Upcoming / refining 💡 to Ready for development on the Connection-Team (Connection-Current-Sprint) board.Jun 24 2025, 11:21 PM
Daimona renamed this task from Update EventStore to handle the new country code field (add, update, read) to Update storage layer to handle the new country code field (add, update, read).Jun 25 2025, 5:55 PM
gerritbot added a comment.Jun 25 2025, 5:57 PM

Change #1163840 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Segregate address-specific code inside AddressStore and add tests

https://gerrit.wikimedia.org/r/1163840

gerritbot added a project: Patch-For-Review.Jun 25 2025, 5:57 PM
Daimona claimed this task.Jun 25 2025, 5:57 PM
Daimona moved this task from Ready for development to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.
gerritbot added a comment.Jun 25 2025, 6:31 PM

Change #1163848 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Introduce a value object to represent addresses

https://gerrit.wikimedia.org/r/1163848

gerritbot added a comment.Jun 27 2025, 4:49 AM

Change #1163840 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Segregate address-specific code inside AddressStore and add tests

https://gerrit.wikimedia.org/r/1163840

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.8; 2025-07-01).Jun 27 2025, 5:00 AM
gerritbot added a comment.Jun 29 2025, 11:24 PM

Change #1163848 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Introduce a value object to represent addresses

https://gerrit.wikimedia.org/r/1163848

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2025, 11:30 PM
gerritbot added a comment.Jun 30 2025, 3:17 PM

Change #1165046 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Have AddressStore::acquireAddressId() take Address

https://gerrit.wikimedia.org/r/1165046

gerritbot added a project: Patch-For-Review.Jun 30 2025, 3:17 PM
gerritbot added a comment.Jun 30 2025, 6:11 PM

Change #1165083 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Minor adjustments for AddressStoreTest in preparation of migration

https://gerrit.wikimedia.org/r/1165083

gerritbot added a comment.Jul 2 2025, 6:16 PM

Change #1165059 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Start reading country schema migration flag in AddressStore

https://gerrit.wikimedia.org/r/1165059

gerritbot added a comment.Jul 4 2025, 12:47 AM

Change #1165046 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Have AddressStore::acquireAddressId() take Address

https://gerrit.wikimedia.org/r/1165046

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.9; 2025-07-08); removed MW-1.45-notes (1.45.0-wmf.8; 2025-07-01).Jul 4 2025, 1:01 AM
gerritbot added a comment.Jul 4 2025, 1:22 AM

Change #1165083 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Minor adjustments for AddressStoreTest in preparation of migration

https://gerrit.wikimedia.org/r/1165083

gerritbot added a comment.Jul 7 2025, 2:56 PM

Change #1165059 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Start reading country schema migration flag in AddressStore

https://gerrit.wikimedia.org/r/1165059

Maintenance_bot removed a project: Patch-For-Review.Jul 7 2025, 3:31 PM
gerritbot added a comment.Jul 8 2025, 1:37 PM

Change #1166419 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] AddressStore: implement NEW stages for the country migration

https://gerrit.wikimedia.org/r/1166419

gerritbot added a project: Patch-For-Review.Jul 8 2025, 1:37 PM
Daimona moved this task from Development In Progress 💻 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Jul 8 2025, 2:18 PM
gerritbot added a comment.Jul 12 2025, 1:19 PM

Change #1166419 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] AddressStore: implement NEW stages for the country migration

https://gerrit.wikimedia.org/r/1166419

Daimona moved this task from Code Review 💬 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.Jul 12 2025, 1:29 PM

QA notes: not directly testable. At most, you could test that nothing broke, if you'd like.

Maintenance_bot removed a project: Patch-For-Review.Jul 12 2025, 1:30 PM
ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.10; 2025-07-15); removed MW-1.45-notes (1.45.0-wmf.9; 2025-07-08).Jul 12 2025, 2:00 PM
vaughnwalters moved this task from QA 🐛 to Product sign-off 🖌️ on the Connection-Team (Connection-Current-Sprint) board.Jul 22 2025, 3:33 AM
vaughnwalters subscribed.
In T397273#10997303, @Daimona wrote:

QA notes: not directly testable. At most, you could test that nothing broke, if you'd like.

Extension is working as expected. Sending to product sign off just for visibility.

ifried closed this task as Resolved.Aug 21 2025, 5:32 PM
ifried moved this task from Product sign-off 🖌️ to Done 🏁 on the Connection-Team (Connection-Current-Sprint) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits