In T313354, we made address and country optional. We also added a message along the lines of The venue address will be made available by the organizers when an event has no address and no country. Now we are making the country a required field for in-person events, so the previous condition (no address AND no country) will never be true. Therefore, we need to decide when the "venue not available" message is shown. The logical choice is to show it when there is no address, but then would we also display the country below the message? And any special style or separation between the two?

Aside from the above, is my understanding correct in that nothing else will change? That is, we still display the address as entered by the user, and then the country on a separate line?

Hey @Daimona,

I have actually been wanting to change the "The venue address will be made available by the organizers" message for a while. I think it is confusing because it assumes that the organizer will do something (i.e., share the venue address) which may or may not happen. I also just find the language awkward, at least in English. So, this is a good opportunity for an update.

Maybe we can update the message to state: "The venue location has not yet been shared by the organizers." This makes it more clear that the specific venue location is not yet available, even if the country is available. I understand that some wikis may have the old copy and updates to the translation may take a while, but the older message is still okay enough in the meantime.

As for where/when to display this message: We would display the message whenever the address field is blank. I think the message should appear below the country information, since the user wants to first see the information that is available and useful (country) followed by information on what is not yet available. However, I know this is a bit awkward because we usually display the address before the country. Let me know if this over-complicates things!

And, yes, the normal behavior when the address is entered will remain the same -- i.e., display address and then display country on a separate line.

In T397274#10989945, @ifried wrote:

Maybe we can update the message to state: "The venue location has not yet been shared by the organizers." This makes it more clear that the specific venue location is not yet available, even if the country is available. I understand that some wikis may have the old copy and updates to the translation may take a while, but the older message is still okay enough in the meantime.

SGTM, this would be a trivial copy change.

As for where/when to display this message: We would display the message whenever the address field is blank. I think the message should appear below the country information, since the user wants to first see the information that is available and useful (country) followed by information on what is not yet available. However, I know this is a bit awkward because we usually display the address before the country. Let me know if this over-complicates things!

I think the ordering does not affect complexity. I mostly just wanted to make sure that mixing user-entered information (the country) and a notice was fine from a design perspective. Also, here's a quick demo of your proposal, to confirm that it matches your expectations and it looks OK.

No address, no country	Country, no address

Thanks for sharing the demo!

This looks good to me. I can update the AC.

@Daimona am I right in thinking this is already implemented?

In T397274#11024985, @MHorsey-WMF wrote:

@Daimona am I right in thinking this is already implemented?

Not entirely. There's a copy change as discussed above (already reflected in the AC). Also, the current logic for displaying that message kicks in if there are (no address) AND (no country), which is always going to be false with mandatory country; so, we want it to trigger when there is no address (and still display a country if there's one). Maybe look into adding this to EventFormatter::formatAddress (for example, have callers pass in a message for "venue not available").

Change #1172028 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Modify Event Formatter to display message when address is not set

https://gerrit.wikimedia.org/r/1172028

Change #1172028 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Modify Event Formatter to display message when address is not set

https://gerrit.wikimedia.org/r/1172028

Acceptance Criteria:

• Given a user is on Special:EventDetails/{eventID},
  • And the event is In Person or Hybrid
    • ✅ Then the user must see the country name,

In person	Hybrid

• • And the country name must be in their language QA note - this line needs to be removed from the AC and will not happen until the migration to country dropdown happens
• And if there is no address,
  • ✅ Display the country (if there is one),
  • ✅ And then display the following text below: "The venue location has not yet been shared by the organizers."

In person	Hybrid

AC met, sending to design sign off

looks good! Sending to product sign off