When adding a statement, the `data-property-id` attribute is empty
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	jhsoby
	Jun 18 2025, 8:43 AM

Description

Steps to replicate the issue (include links if applicable):

Go to https://www.wikidata.org/wiki/Q4115189
Add a new statement: P131 -> something
Inspect the HTML of new item that was added to the DOM

What happens?:

The element with ID P131 has an attribute data-property-id, but it is empty.
If you compare it to the pre-existing statements that were there when the page loaded, they all have the actual property ID in that attribute.

What should have happened instead?:

The attribute should have the correct property ID in it.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Set data-property-id attribute when updating statement	mediawiki/extensions/Wikibase	master	+6 -1

Customize query in gerrit

Related Objects

Mentioned Here: P131 Failures when applying 178205

Event Timeline

jhsoby created this task.Jun 18 2025, 8:43 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 18 2025, 8:43 AM

It didn't get reported here because I hadn't attached the task to the patch, but I tested the patch (not sure where @gerritbot is?) by creating two Patch Demos, one with no changes and one with my patch, and then comparing the result when adding a new property to an item).

Vanilla Patch Demo: https://patchdemo.wmcloud.org/wikis/fb0c511e2d/wiki/Item:Q1
Patched Patch Demo: https://patchdemo.wmcloud.org/wikis/7b5d467ef6/wiki/Item:Q1

(This is a roundabout way of saying I don't have a local Wikibase setup to test with…)

jhsoby added a project: Patch-For-Review.Jun 18 2025, 9:19 AM

(not sure where @gerritbot is?)

If I had to completely guess, maybe Gerrit isn't recognising the patch as being linked to this bug due to the extra blank line in-between the Bug: & Change-Id: footers?

Change #1160698 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Wikibase@master] Set data-property-id attribute when updating statement

https://gerrit.wikimedia.org/r/1160698

In T397288#10927083, @A_smart_kitten wrote:

(not sure where @gerritbot is?)

If I had to completely guess, maybe Gerrit isn't recognising the patch as being linked to this bug due to the extra blank line in-between the Bug: & Change-Id: footers?

Good hunch! Thanks!

Change #1160698 merged by jenkins-bot: