Page MenuHomePhabricator

[Client Errors] TAHS - TypeError: Cannot read property '0' of undefined
Closed, ResolvedPublic

Description

Several client errors appeared via alert emails and can be seen on logstash: https://logstash.wikimedia.org/app/dashboards#/view/AXDBY8Qhh3Uj6x1zCF56?_g=h@67649a6&_a=h@b22e7b4

Most errors are on English Wikipedia
Errors are related to TAHS and the ResizeObserver.
Main error message is TypeError: Cannot read property '0' of undefined

stack_trace at ResizeObserver.<anonymous> https://en.m.wikipedia.org/w/load.php?lang=en&modules=mediawiki.codex.typeaheadSearch%7Cvue&skin=minerva&version=ldg5d:14:347

Revert patch: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1159542

Event Timeline

Change #1162991 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[design/codex@main] useResizeObserver: Check for valid ResizeObserver entry

https://gerrit.wikimedia.org/r/1162991

seems like a browser support issue, all the errors are from firefox/android https://logstash.wikimedia.org/app/dashboards#/view/AXDBY8Qhh3Uj6x1zCF56?_g=h@218e8f9&_a=h@2f0339b
the problematic code is in codex, useResizeObserver composable, which is used by codex dialog

dunno how accurate user agents are in general, but the most errors seems to be coming from kindles

Change #1162991 merged by jenkins-bot:

[design/codex@main] useResizeObserver: Check for valid ResizeObserver entry

https://gerrit.wikimedia.org/r/1162991

Change #1163459 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v2.1.0 to v2.2.0

https://gerrit.wikimedia.org/r/1163459

Change #1163459 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v2.1.0 to v2.2.0

https://gerrit.wikimedia.org/r/1163459

Jdrewniak removed Edtadros as the assignee of this task.
Jdrewniak assigned this task to Edtadros.
Jdrewniak added a subscriber: Edtadros.

@Jdrewniak is this something verifiable on the UI or through devtools? Or in beta or just prod?

This comment was removed by Edtadros.
Edtadros updated the task description. (Show Details)

just returning this to in progress, I moved this task by mistake.

@bwang did we confirm the production errors stopped?

Checked with @LMora-WMF and this can be closed.