Page MenuHomePhabricator

[mobile] Help button is clickable when not visible
Closed, ResolvedPublicBUG REPORT

Description

The issue is present on mobile for the following scenarios (see the details In Steps)

  • deleting Template
  • deleting wikifunction
  • deleting table
  • deleting reference list

Steps to replicate the issue :

What happens?:

  • click on the Delete option (precisely on the label 'Delete") - the Help overlay will appear (see the gif below) the gif is about wikifunction dialog but the same issue is present with the template dialog:
    function_help dialog confilict2.gif (784×375 px, 147 KB)

What should have happened instead?:

  • the Help button should not be clickable if it's not visible

Software version : the issue is present on wmf.6

Notes

  • the issue is also present on the following VE insert options

    (1) Insert table - this case is especially severe since an inserted table on mobile can be deleted only via the source editor.

Screenshot 2025-06-18 at 3.16.14 PM.png (1×754 px, 330 KB)

  • Clicking on 'Delete" icon doesn't produce any actions
  • Clicking on X brings up the Help panel overlay and the Console error
ve.ui.MWAceEditorWidget.js:406 Uncaught TypeError: Cannot read properties of null (reading 'fail')
    at ve.ui.MWAceEditorWidget.adjustSize (ve.ui.MWAceEditorWidget.js:406:22)
    at OO.ui.MultilineTextInputWidget.onElementAttach (oojs-ui-core.js:12303:7)
    at connectDetectorNode.onConnectOOUI (oojs-ui-core.js:11733:9)
    at HTMLElement.connectedCallback

(2) Insert Referemce List

  • Clicking on 'Delete" icon doesn't produce any actions

Event Timeline

How widespread is this issue? Is this affecting basically all mobile editing on all wikis (for people who have the help-panel enabled)?

How widespread is this issue? Is this affecting basically all mobile editing on all wikis (for people who have the help-panel enabled)?

I've added the summary of the cases when the Help overlay would be present when upon clicking on the Delete button. It's possible to actually delete when you click around the Delete button - so, when the click is outside Help button clickable area, the Delete button will work.

Change #1172624 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] fix(HelpPanel): temporary fix for z-index overlap issues

https://gerrit.wikimedia.org/r/1172624

Change #1172624 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(HelpPanel): temporary fix for z-index overlap issues

https://gerrit.wikimedia.org/r/1172624

Etonkovidova claimed this task.

Re-checked on testwiki wmf.14 along with T397289: Help panel: `?` button is visible and doesn't respond when publish dialog is open

  • DONE deleting Template
  • DONE deleting wikifunction
  • DONE deleting table
  • DONE deleting reference list