Page MenuHomePhabricator

PHP Deprecated: Use of MediaWiki\Xml\Xml::radioLabel was deprecated in MediaWiki 1.42. [Called from MediaWiki\Extension\CentralAuth\Special\SpecialMultiLock::showStatusForm]
Closed, ResolvedPublicPRODUCTION ERROR

Assigned To
Authored By
Aklapper
Jun 19 2025, 11:13 AM
Referenced Files
F62402715: html.diff
Jun 20 2025, 2:03 PM
F62402717: after.html
Jun 20 2025, 2:03 PM
F62402716: before.html
Jun 20 2025, 2:03 PM
F62402718: after.png
Jun 20 2025, 2:03 PM
F62402719: before.png
Jun 20 2025, 2:03 PM
Subscribers

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of MediaWiki\Xml\Xml::radioLabel was deprecated in MediaWiki 1.42. [Called from MediaWiki\Extension\CentralAuth\Special\SpecialMultiLock::showStatusForm]
FrameLocationCall
from/srv/mediawiki/php-1.45.0-wmf.6/extensions/CentralAuth/includes/Special/SpecialMultiLock.php(210)
#0[internal function]MediaWiki\Exception\MWExceptionHandler::handleError(int, string, string, string)
#1/srv/mediawiki/php-1.45.0-wmf.6/includes/debug/MWDebug.php(386)trigger_error(string, int)
#2/srv/mediawiki/php-1.45.0-wmf.6/includes/debug/MWDebug.php(357)MediaWiki\Debug\MWDebug::sendRawDeprecated(string, bool, string)
#3/srv/mediawiki/php-1.45.0-wmf.6/includes/debug/MWDebug.php(238)MediaWiki\Debug\MWDebug::deprecatedMsg(string, string, string, int)
#4/srv/mediawiki/php-1.45.0-wmf.6/includes/GlobalFunctions.php(782)MediaWiki\Debug\MWDebug::deprecated(string, string, string, int)
#5/srv/mediawiki/php-1.45.0-wmf.6/includes/xml/Xml.php(503)wfDeprecated(string, string)
#6/srv/mediawiki/php-1.45.0-wmf.6/extensions/CentralAuth/includes/Special/SpecialMultiLock.php(210)MediaWiki\Xml\Xml::radioLabel(string, string, string, string, bool)
#7/srv/mediawiki/php-1.45.0-wmf.6/extensions/CentralAuth/includes/Special/SpecialMultiLock.php(385)MediaWiki\Extension\CentralAuth\Special\SpecialMultiLock->showStatusForm()
#8/srv/mediawiki/php-1.45.0-wmf.6/extensions/CentralAuth/includes/Special/SpecialMultiLock.php(114)MediaWiki\Extension\CentralAuth\Special\SpecialMultiLock->showUserTable()
#9/srv/mediawiki/php-1.45.0-wmf.6/includes/specialpage/SpecialPage.php(732)MediaWiki\Extension\CentralAuth\Special\SpecialMultiLock->execute(null)
#10/srv/mediawiki/php-1.45.0-wmf.6/includes/specialpage/SpecialPageFactory.php(1722)MediaWiki\SpecialPage\SpecialPage->run(null)
#11/srv/mediawiki/php-1.45.0-wmf.6/includes/actions/ActionEntryPoint.php(499)MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#12/srv/mediawiki/php-1.45.0-wmf.6/includes/actions/ActionEntryPoint.php(143)MediaWiki\Actions\ActionEntryPoint->performRequest()
#13/srv/mediawiki/php-1.45.0-wmf.6/includes/MediaWikiEntryPoint.php(198)MediaWiki\Actions\ActionEntryPoint->execute()
#14/srv/mediawiki/php-1.45.0-wmf.6/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#15/srv/mediawiki/w/index.php(3)require(string)
#16{main}
Impact
Notes

Similar game as T394403 in FlaggedRevs.

Details

MediaWiki Version
1.45.0-wmf.6
Request URL
https://meta.wikimedia.org/wiki/Special:MultiLock
Related Changes in Gerrit:

Event Timeline

Change #1161969 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/CentralAuth@master] Convert SpecialMultiLock to HTMLForm

https://gerrit.wikimedia.org/r/1161969

I found that changes like these are difficult to review, so if we're going to suffer anyway, we might as well take care of more technical debt all at once. Hence the rewrite.

The form appearance is almost unchanged:

BeforeAfter
before.png (1,255×902 px, 44 KB)
after.png (1,255×886 px, 42 KB)

Prettified HTML output before and after, for ease of review:

The form fields names/values should be unchanged, but many ids change. This may break user CSS/JS, if anything customized this page.

Change #1161969 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Convert SpecialMultiLock to HTMLForm

https://gerrit.wikimedia.org/r/1161969