Page MenuHomePhabricator

xLab: Gracefully handle IdP config missing
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

While working on T396761: Create MW Docker configuration recipe for xLab, I noticed that xLab will:

  1. Log an error when the IDP_CLIENT_SECRET env variable isn't set but authentication is otherwise disabled (i.e. NODE_ENV === "development")

AC

  • When authentication is disabled, no error is logged when the IDP_CLIENT_SECRET env variable is or isn't set

Event Timeline

phuedx renamed this task from Gracefully handle SAL and IdP config missing to xLab: Gracefully handle SAL and IdP config missing.Jun 19 2025, 3:19 PM
Milimetric triaged this task as Medium priority.Jul 17 2025, 3:19 PM
Milimetric moved this task from Incoming to READY TO GROOM on the Test Kitchen board.
phuedx set the point value for this task to 1.Sep 12 2025, 10:58 AM

I'm being bold and estimating this as a 1-pointer. This is adding trivial checks before logging an error to the console.

@dr0ptp4kt does this relate to your Hypothesis?

Not exactly, but close enough. I had mentioned this task over in T404260: xLab: log create/update/delete of A/B test configuration to SAL as related. I've now set T404260 as a parent task of this here T397462.

In T404260#11362889 we're talking about just getting rid of mwbot, and I'd consider this to be the same part of the code to delete. Related: T395839: [SPIKE] Investigate alternatives for mwbot's use of the request library

dr0ptp4kt claimed this task.

We deleted stuff. Marking as Resolved.

dr0ptp4kt renamed this task from xLab: Gracefully handle SAL and IdP config missing to xLab: Gracefully handle IdP config missing.Dec 16 2025, 4:38 PM
dr0ptp4kt reopened this task as Open.
dr0ptp4kt updated the task description. (Show Details)