See also {T397396}

Leaving to Trust and Safety Product Team unless there is a specific ask of the Security Team here.

thanksGiven and thanksReceived are from ThanksQueryHelper in Thanks, so tagging that extension.

globalEditCount is from MediaWiki-extensions-CentralAuth getGlobalEditCount, so tagging that extension here too.

totalEditCount is from UserEditTracker in core -> MediaWiki-User-management

newArticlesCount and revertedEditCount this is from GrowthExperiments

Out of those numbers, only thanksGiven/Received and newArticlesCount/revertedEditCount are dynamically calculated. The edit counts are implemented by bumping a counter, so I don't think we can/should do much there – it is a widely known fact the edit counter does not always represent what you see in Special:Contributions.

OK, what I think we (Trust and Safety Product Team) should do for UserInfoCard:

• Update ThanksQueryHelper to only include log_deleted = 0 in its queries. If someone in the future wants to include support for adding an Authority to include counts based on suppressed log entries, that would be fine, but I dont' think we need to do it now. On enwiki, out of 4,259,843 log entries for thanks, only 469 are suppressed.
• newArticlesCount - we can update ComputedUserImpactLookup#getCreatedArticleCount in GrowthEpxeriments to check that log_deleted is 0

What I propose we don't do anything about:

• As @Urbanecm_WMF notes above: both methods in CentralAuth for calculating edit counts don't take into account the authority that is checking the count, and the edit tracker in core doesn't do that either. I propose that we leave this as a "won't fix".
• revertedEditCount already checks for rev_deleted ($queryBuilder->where( $db->bitAnd( 'rev_deleted', RevisionRecord::DELETED_USER ) . ' = 0' );), so I think there is nothing more to be done there.

In T397497#11027301, @kostajh wrote:

OK, what I think we (Trust and Safety Product Team) should do for UserInfoCard:

• Update ThanksQueryHelper to only include log_deleted = 0 in its queries. If someone in the future wants to include support for adding an Authority to include counts based on suppressed log entries, that would be fine, but I dont' think we need to do it now. On enwiki, out of 4,259,843 log entries for thanks, only 469 are suppressed.
• newArticlesCount - we can update ComputedUserImpactLookup#getCreatedArticleCount in GrowthEpxeriments to check that log_deleted is 0

Here are patches for GrowthExperiments and Thanks to address these two points:

+2, I've reviewed both patches and they look ok for me

In T397497#11042883, @mszwarc wrote:

In T397497#11027301, @kostajh wrote:

OK, what I think we (Trust and Safety Product Team) should do for UserInfoCard:

• Update ThanksQueryHelper to only include log_deleted = 0 in its queries. If someone in the future wants to include support for adding an Authority to include counts based on suppressed log entries, that would be fine, but I dont' think we need to do it now. On enwiki, out of 4,259,843 log entries for thanks, only 469 are suppressed.
• newArticlesCount - we can update ComputedUserImpactLookup#getCreatedArticleCount in GrowthEpxeriments to check that log_deleted is 0

Here are patches for GrowthExperiments and Thanks to address these two points:

T397497_GrowthExperiments.patch2 KBDownload

T397497_Thanks.patch3 KBDownload

Deployed

Given the comment in T402600#11119989, would it be fine to upload these changes to Gerrit as well for Thanks and GrowthExperiments? And, in that vein, what would be the process to make this task itself public?

In T397497#11131311, @Michael wrote:

Given the comment in T402600#11119989, would it be fine to upload these changes to Gerrit as well for Thanks and GrowthExperiments? And, in that vein, what would be the process to make this task itself public?

ext:Thanks is actually bundled since 1.40. So we'd want to keep that one tracked and embargoed until the upcoming core security release (T397766, due out towards the end of September 2025). The ext:GrowthExperiments patch would be fine to push up to gerrit, especially if it's causing conflicts with other, public work, but this task should remain protected until the aforementioned core security release is out. I've added @gerritbot as a subscriber to this task, so if you do push the ext:GrowthExperiments patch up to gerrit, it should still post the changes here.

Change #1189190 had a related patch set uploaded (by Reedy; author: Mszwarc):

[mediawiki/extensions/GrowthExperiments@master] SECURITY: Exclude deleted log entries when counting created articles

https://gerrit.wikimedia.org/r/1189190

Change #1189190 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SECURITY: Exclude deleted log entries when counting created articles

https://gerrit.wikimedia.org/r/1189190

Change #1189252 had a related patch set uploaded (by Reedy; author: Mszwarc):

[mediawiki/extensions/GrowthExperiments@REL1_44] SECURITY: Exclude deleted log entries when counting created articles

https://gerrit.wikimedia.org/r/1189252

Change #1189252 abandoned by Reedy:

[mediawiki/extensions/GrowthExperiments@REL1_44] SECURITY: Exclude deleted log entries when counting created articles

https://gerrit.wikimedia.org/r/1189252

Change #1193240 had a related patch set uploaded (by Reedy; author: Mszwarc):

[mediawiki/extensions/Thanks@REL1_44] SECURITY: Exclude deleted entries when counting thanks

https://gerrit.wikimedia.org/r/1193240

Change #1193240 merged by jenkins-bot:

[mediawiki/extensions/Thanks@REL1_44] SECURITY: Exclude deleted entries when counting thanks

https://gerrit.wikimedia.org/r/1193240

Change #1193250 had a related patch set uploaded (by Reedy; author: Mszwarc):

[mediawiki/extensions/Thanks@master] SECURITY: Exclude deleted entries when counting thanks

https://gerrit.wikimedia.org/r/1193250

Change #1193250 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] SECURITY: Exclude deleted entries when counting thanks

https://gerrit.wikimedia.org/r/1193250

Change #1193431 had a related patch set uploaded (by Reedy; author: Mszwarc):

[mediawiki/extensions/Thanks@REL1_43] SECURITY: Exclude deleted entries when counting thanks

https://gerrit.wikimedia.org/r/1193431

Change #1193431 merged by jenkins-bot:

[mediawiki/extensions/Thanks@REL1_43] SECURITY: Exclude deleted entries when counting thanks

https://gerrit.wikimedia.org/r/1193431