Page MenuHomePhabricator

VisualDiff should use vertical ellipsis consistenly
Closed, ResolvedPublic

Assigned To
Authored By
Esanders
Jun 20 2025, 12:58 PM
Referenced Files
F65780279: Screenshot 2025-08-18 at 10.03.13 PM.png
Aug 18 2025, 11:23 PM
F65699114: image.png
Jul 31 2025, 11:52 PM
F65699112: image.png
Jul 31 2025, 11:52 PM
F65699110: image.png
Jul 31 2025, 11:52 PM
F65699091: image.png
Jul 31 2025, 11:38 PM
F62402231: image.png
Jun 20 2025, 12:58 PM
F62402225: image.png
Jun 20 2025, 12:58 PM

Description

To hide context we use a vertical ellipsis, both when hiding paragraphs and when hiding parts of a reference list:

image.png (436×885 px, 22 KB)

But hidden parts of a plain list use a horizontal ellipsis:

image.png (416×885 px, 54 KB)

Related Objects

Mentioned In
T403745: ve.track module isn't loaded when launching 2017 editor on a page with discussiontools enabled
T403741: Move annotation-removal logic out of AnnotationAction into SurfaceFragment
T400849: Enable "Thanks" from talk pages as an opt-in beta feature
T391521: VE: Deleting sub-ref attached to main content does not orphan other sub-refs in same article
T397145: Move footnote numbering information out of singleton document cache
T401890: Long link labels don't show ellipsis in link context on mobile
T402392: Bring basic reference functionality into VisualEditor standalone
T302413: Visual diff of templates inside the table shows all descriptions at the bottom, in backwards order
T402717: ClipboardHandler preserves existing ImportedDataAnnotation when pasting over previously-pasted content
Mentioned Here
rGVEDa5bd08c8bc2a: Move ve.track.js into a separate module
T302413: Visual diff of templates inside the table shows all descriptions at the bottom, in backwards order
T391521: VE: Deleting sub-ref attached to main content does not orphan other sub-refs in same article
T397145: Move footnote numbering information out of singleton document cache
T400849: Enable "Thanks" from talk pages as an opt-in beta feature
T401890: Long link labels don't show ellipsis in link context on mobile
T402392: Bring basic reference functionality into VisualEditor standalone
T402717: ClipboardHandler preserves existing ImportedDataAnnotation when pasting over previously-pasted content
T403741: Move annotation-removal logic out of AnnotationAction into SurfaceFragment
T403745: ve.track module isn't loaded when launching 2017 editor on a page with discussiontools enabled

Event Timeline

Change #1143798 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] DiffElement: Use vertical ellipsis for list spacers, matching content spacers

https://gerrit.wikimedia.org/r/1143798

Change #1143798 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] DiffElement: Use vertical ellipsis for list spacers, matching content spacers

https://gerrit.wikimedia.org/r/1143798

Change #1162081 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a6dd246fa)

https://gerrit.wikimedia.org/r/1162081

Change #1162081 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a6dd246fa)

https://gerrit.wikimedia.org/r/1162081

Esanders added a project: Editing QA.
Esanders moved this task from Inbox to Low Priority on the Editing QA board.

A user in zhwiki reported that indented list item inside .ve-ui-diffElement-spacer gets the grey color of context line, instead of the normal body text color of changed line (link). Test cases were provided: good for unindented item #1, good for indented item when the unindented parent is present in diff #2, bad for indented item when the parent is not present #3. A screenshot was uploaded to https://imgur.com/a/R5Z6vAd.

The bad colors are especially annoying in discussion diffs, e.g.: https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&diff=prev&oldid=1300691208

image.png (1×1 px, 129 KB)

The added comment is unreadable on the green diff background, and the context comments are shown in two different shades of grey for no reason.

Change #1174847 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] DiffElement: Fix colors for content inside list spacers

https://gerrit.wikimedia.org/r/1174847

A screenshot was uploaded to https://imgur.com/a/R5Z6vAd.

Copied for the future:

image.png (134×363 px, 4 KB)

image.png (157×369 px, 5 KB)

image.png (168×369 px, 5 KB)

Ryasmeen subscribed.

In both scenarios, VisualDiff is using vertical ellipsis:

Screenshot 2025-08-18 at 10.03.13 PM.png (1×1 px, 93 KB)

Change #1174847 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] DiffElement: Fix colors for content inside list spacers

https://gerrit.wikimedia.org/r/1174847

Change #1185179 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a5bd08c8b)

https://gerrit.wikimedia.org/r/1185179

Change #1185179 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a5bd08c8b)

https://gerrit.wikimedia.org/r/1185179

Change #1185982 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.17] Update VE core submodule to master (a5bd08c8b)

https://gerrit.wikimedia.org/r/1185982

Change #1185982 abandoned by DLynch:

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.17] Update VE core submodule to master (a5bd08c8b)

Reason:

Would need to do the subrepo backport anyway

https://gerrit.wikimedia.org/r/1185982

Change #1185982 restored by DLynch:

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.17] Update VE core submodule to master (a5bd08c8b)

https://gerrit.wikimedia.org/r/1185982

Change #1185982 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.17] Update VE core submodule to master (a5bd08c8b)

https://gerrit.wikimedia.org/r/1185982

Mentioned in SAL (#wikimedia-operations) [2025-09-08T20:11:02Z] <kemayo@deploy1003> kemayo, esanders: Backport for [[gerrit:1185991|Enable DT thanks at mediawikiwiki (T400849)]], [[gerrit:1185982|Update VE core submodule to master (a5bd08c8b) (T302413 T391521 T397145 T401890 T402392 T397518 T402717 T403741 T403745)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-09-08T20:17:50Z] <kemayo@deploy1003> Finished scap sync-world: Backport for [[gerrit:1185991|Enable DT thanks at mediawikiwiki (T400849)]], [[gerrit:1185982|Update VE core submodule to master (a5bd08c8b) (T302413 T391521 T397145 T401890 T402392 T397518 T402717 T403741 T403745)]] (duration: 13m 05s)